Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1756793004: Chrome-side patch for IsAppInstalled. (Closed)

Created:
4 years, 9 months ago by Daniel Nishi
Modified:
3 years, 10 months ago
Reviewers:
esprehn
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@splitpatch2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chrome-side patch for IsAppInstalled.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+646 lines, -5 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A content/common/installedapp/installed_app_provider.mojom View 1 chunk +11 lines, -0 lines 0 comments Download
A content/common/installedapp/installed_app_provider_impl.h View 1 chunk +19 lines, -0 lines 0 comments Download
A content/common/installedapp/installed_app_provider_impl_default.cc View 1 chunk +44 lines, -0 lines 0 comments Download
A + content/common/installedapp/related_application.mojom View 1 chunk +5 lines, -4 lines 0 comments Download
M content/content.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_common_mojo_bindings.gyp View 2 chunks +3 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/android/BUILD.gn View 2 chunks +7 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ServiceRegistrar.java View 3 chunks +18 lines, -0 lines 0 comments Download
A content/public/android/java/src/org/chromium/content/browser/installedapp/InstalledAppProviderImpl.java View 1 chunk +146 lines, -0 lines 0 comments Download
A content/public/android/junit/src/org/chromium/content/browser/installedapp/InstalledAppProviderTest.java View 1 chunk +178 lines, -0 lines 0 comments Download
A content/renderer/installedapp/installed_app_dispatcher.h View 1 chunk +53 lines, -0 lines 0 comments Download
A content/renderer/installedapp/installed_app_dispatcher.cc View 1 chunk +81 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 4 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/installedapp/api-defined.html View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/installedapp/api-defined-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 4 (1 generated)
esprehn
Your copyrights are 2016, please don't add more code to content/renderer, this should just talk ...
3 years, 10 months ago (2017-02-02 07:26:23 UTC) #2
esprehn
On 2017/02/02 at 07:26:23, esprehn wrote: > Your copyrights are 2016, please don't add more ...
3 years, 10 months ago (2017-02-02 07:32:33 UTC) #3
Matt Giuca
3 years, 10 months ago (2017-02-02 23:13:38 UTC) #4
Message was sent while issue was closed.
On 2017/02/02 07:32:33, esprehn wrote:
> On 2017/02/02 at 07:26:23, esprehn wrote:
> > Your copyrights are 2016, please don't add more code to content/renderer,
this
> should just talk mojo directly from inside blink. This is also using the old
ipc
> system and routing IDs which we don't let folks do anymore.
> 
> Woops wrong CL.

Haha, good to know my changes are on the right track :)

Powered by Google App Engine
This is Rietveld 408576698