Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2762293002:
Avoid segfault for missing StateKeysBroker (Closed)
|
Created:
3 years, 9 months ago by Thiemo Nagel Modified:
3 years, 9 months ago CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, zentaro Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAvoid segfault for missing StateKeysBroker
This should work around the problem until the root cause has been fixed.
(Also remove somewhat irritating curly braces from switch cases.)
BUG=703658
Review-Url: https://codereview.chromium.org/2762293002
Cr-Commit-Position: refs/heads/master@{#458739}
Committed: https://chromium.googlesource.com/chromium/src/+/ec080c375b6006502f1b37145761fd3a1da29469
Patch Set 1 #Patch Set 2 : Fix error messages #
Total comments: 4
Patch Set 3 : Add reference to crbug #Messages
Total messages: 20 (13 generated)
The CQ bit was checked by tnagel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by tnagel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Avoid segfault for missing StateKeysBroker This should work around the problem until the root cause has been fixed. BUG=703658 ========== to ========== Avoid segfault for missing StateKeysBroker This should work around the problem until the root cause has been fixed. (Also remove somewhat irritating curly braces from switch cases.) BUG=703658 ==========
tnagel@chromium.org changed reviewers: + atwilson@chromium.org, rsorokin@chromium.org
Hi Drew, could you please take a look? (Owners are scarce here.) Thank you, Thiemo
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
tnagel@chromium.org changed reviewers: + bartfab@chromium.org - atwilson@chromium.org
lgtm https://codereview.chromium.org/2762293002/diff/20001/chrome/browser/chromeos... File chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc (right): https://codereview.chromium.org/2762293002/diff/20001/chrome/browser/chromeos... chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc:220: policy::ServerBackedStateKeysBroker* state_keys_broker = Nit: const https://codereview.chromium.org/2762293002/diff/20001/chrome/browser/chromeos... chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc:226: // TODO(tnagel): Prevent missing state keys broker in the first place. Nit: Can you reference a bug number?
Thanks a lot for the quick review! https://codereview.chromium.org/2762293002/diff/20001/chrome/browser/chromeos... File chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc (right): https://codereview.chromium.org/2762293002/diff/20001/chrome/browser/chromeos... chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc:220: policy::ServerBackedStateKeysBroker* state_keys_broker = On 2017/03/22 13:17:07, bartfab (slow) wrote: > Nit: const ServerBackedStateKeysBroker::RequestStateKeys() is not const. https://codereview.chromium.org/2762293002/diff/20001/chrome/browser/chromeos... chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc:226: // TODO(tnagel): Prevent missing state keys broker in the first place. On 2017/03/22 13:17:07, bartfab (slow) wrote: > Nit: Can you reference a bug number? Done.
The CQ bit was checked by tnagel@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bartfab@chromium.org, rsorokin@chromium.org Link to the patchset: https://codereview.chromium.org/2762293002/#ps40001 (title: "Add reference to crbug")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490188992376080,
"parent_rev": "ca8c398302a2c20ec014439d7d74ca1eeb6c9e5a", "commit_rev":
"ec080c375b6006502f1b37145761fd3a1da29469"}
Message was sent while issue was closed.
Description was changed from ========== Avoid segfault for missing StateKeysBroker This should work around the problem until the root cause has been fixed. (Also remove somewhat irritating curly braces from switch cases.) BUG=703658 ========== to ========== Avoid segfault for missing StateKeysBroker This should work around the problem until the root cause has been fixed. (Also remove somewhat irritating curly braces from switch cases.) BUG=703658 Review-Url: https://codereview.chromium.org/2762293002 Cr-Commit-Position: refs/heads/master@{#458739} Committed: https://chromium.googlesource.com/chromium/src/+/ec080c375b6006502f1b37145761... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/ec080c375b6006502f1b37145761... |
