Avoid segfault for missing StateKeysBroker

chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 199 matching lines @@
 }
 
 std::unique_ptr<AutoEnrollmentController::ProgressCallbackList::Subscription>
 AutoEnrollmentController::RegisterProgressCallback(
     const ProgressCallbackList::CallbackType& callback) {
   return progress_callbacks_.Add(callback);
 }
 
 void AutoEnrollmentController::OnOwnershipStatusCheckDone(
     DeviceSettingsService::OwnershipStatus status) {
-  switch (status) {
-    case DeviceSettingsService::OWNERSHIP_NONE: {
+  policy::ServerBackedStateKeysBroker* state_keys_broker =
       g_browser_process->platform_part()
           ->browser_policy_connector_chromeos()
-          ->GetStateKeysBroker()
-          ->RequestStateKeys(
-              base::Bind(&AutoEnrollmentController::StartClient,
-                         client_start_weak_factory_.GetWeakPtr()));
-      break;
-    }
-    case DeviceSettingsService::OWNERSHIP_TAKEN: {
+          ->GetStateKeysBroker();
+  switch (status) {
+    case DeviceSettingsService::OWNERSHIP_NONE:
+      // TODO(tnagel): Prevent missing state keys broker in the first place.
+      // https://crbug.com/703658
+      if (!state_keys_broker) {
+        LOG(ERROR) << "State keys broker missing.";
+        UpdateState(policy::AUTO_ENROLLMENT_STATE_NO_ENROLLMENT);
+        return;
+      }
+      state_keys_broker->RequestStateKeys(
+          base::Bind(&AutoEnrollmentController::StartClient,
+                     client_start_weak_factory_.GetWeakPtr()));
+      return;
+    case DeviceSettingsService::OWNERSHIP_TAKEN:
       VLOG(1) << "Device already owned, skipping auto-enrollment check.";
       UpdateState(policy::AUTO_ENROLLMENT_STATE_NO_ENROLLMENT);
-      break;
-    }
-    case DeviceSettingsService::OWNERSHIP_UNKNOWN: {
+      return;
+    case DeviceSettingsService::OWNERSHIP_UNKNOWN:
       LOG(ERROR) << "Ownership unknown, skipping auto-enrollment check.";
       UpdateState(policy::AUTO_ENROLLMENT_STATE_NO_ENROLLMENT);
-      break;
-    }
+      return;
   }
 }
 
 void AutoEnrollmentController::StartClient(
     const std::vector<std::string>& state_keys) {
   if (state_keys.empty()) {
     LOG(ERROR) << "No state keys available!";
     UpdateState(policy::AUTO_ENROLLMENT_STATE_NO_ENROLLMENT);
     return;
   }
@@ skipping 64 matching lines @@
     // keeps the connection open.
     LOG(ERROR) << "AutoEnrollmentClient didn't complete within time limit.";
     UpdateState(policy::AUTO_ENROLLMENT_STATE_CONNECTION_ERROR);
   }
 
   // Reset state.
   Cancel();
 }
 
 }  // namespace chromeos