Move iOS image_fetcher::ImageDecoder to layered component

Move iOS image_fetcher::ImageDecoder to layered component

In general, ImageDecoder is not specific to suggestions and hence the
code does not belong ios/chrome/browser/suggestions.

In particular, we do this to avoid a dependency cycle in a future CL,
due to the integration of ImageFetcher in FaviconService, causing:
ERROR Dependency cycle:
  //ios/chrome/browser/sync:sync ->
  //ios/chrome/browser/bookmarks:bookmarks ->
  //ios/chrome/browser/favicon:favicon ->
  //ios/chrome/browser/suggestions:suggestions ->
  //ios/chrome/browser/sync:sync

BUG=644102, 624761
Review-Url: https://codereview.chromium.org/2762063003
Cr-Commit-Position: refs/heads/master@{#458419}
Committed: https://chromium.googlesource.com/chromium/src/+/a31cd7215e84eee41286dc7f08020c740515ebe5

[mastiz, 2017-03-21 12:52:26]

The CQ bit was checked by mastiz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 12:52:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mastiz, 2017-03-21 12:58:20]

Description was changed from

==========
Move iOS image_fetcher::ImageDecoder to layered component

In general, ImageDecoder is not specific to suggestions and hence the
code does not belong ios/chrome/browser/suggestions.

In particular, we do this to avoid a dependency cycle in a future CL,
causing:
ERROR Dependency cycle:
  //ios/chrome/browser/sync:sync ->
  //ios/chrome/browser/bookmarks:bookmarks ->
  //ios/chrome/browser/favicon:favicon ->
  //ios/chrome/browser/suggestions:suggestions ->
  //ios/chrome/browser/sync:sync

BUG=644102
==========

to

==========
Move iOS image_fetcher::ImageDecoder to layered component

In general, ImageDecoder is not specific to suggestions and hence the
code does not belong ios/chrome/browser/suggestions.

In particular, we do this to avoid a dependency cycle in a future CL,
due to the integration of ImageFetcher in FaviconService, causing:
ERROR Dependency cycle:
  //ios/chrome/browser/sync:sync ->
  //ios/chrome/browser/bookmarks:bookmarks ->
  //ios/chrome/browser/favicon:favicon ->
  //ios/chrome/browser/suggestions:suggestions ->
  //ios/chrome/browser/sync:sync

BUG=644102
==========

[commit-bot: I haz the power, 2017-03-21 12:59:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 12:59:40]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[mastiz, 2017-03-21 13:25:07]

The CQ bit was checked by mastiz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 13:25:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mastiz, 2017-03-21 13:28:50]

mastiz@chromium.org changed reviewers:
+ gambard@chromium.org, mathp@chromium.org

[mastiz, 2017-03-21 13:28:51]

mathp@chromium.org: Please review changes in 
components/image_fetcher
ios/chrome/browser/suggestions

gambard@chromium.org: Please review changes in 
ios/chrome/browser/ntp_snippets

[gambard, 2017-03-21 13:35:29]

lgtm

[mastiz, 2017-03-21 13:39:44]

mastiz@chromium.org changed reviewers:
+ sfiera@chromium.org

[mastiz, 2017-03-21 13:39:45]

sfiera@chromium.org: Please review changes in 
ntp_tiles

[sfiera, 2017-03-21 13:42:25]

LGTM

[mastiz, 2017-03-21 13:43:46]

Description was changed from

==========
Move iOS image_fetcher::ImageDecoder to layered component

In general, ImageDecoder is not specific to suggestions and hence the
code does not belong ios/chrome/browser/suggestions.

In particular, we do this to avoid a dependency cycle in a future CL,
due to the integration of ImageFetcher in FaviconService, causing:
ERROR Dependency cycle:
  //ios/chrome/browser/sync:sync ->
  //ios/chrome/browser/bookmarks:bookmarks ->
  //ios/chrome/browser/favicon:favicon ->
  //ios/chrome/browser/suggestions:suggestions ->
  //ios/chrome/browser/sync:sync

BUG=644102
==========

to

==========
Move iOS image_fetcher::ImageDecoder to layered component

In general, ImageDecoder is not specific to suggestions and hence the
code does not belong ios/chrome/browser/suggestions.

In particular, we do this to avoid a dependency cycle in a future CL,
due to the integration of ImageFetcher in FaviconService, causing:
ERROR Dependency cycle:
  //ios/chrome/browser/sync:sync ->
  //ios/chrome/browser/bookmarks:bookmarks ->
  //ios/chrome/browser/favicon:favicon ->
  //ios/chrome/browser/suggestions:suggestions ->
  //ios/chrome/browser/sync:sync

BUG=644102,624761
==========

[mastiz, 2017-03-21 13:48:38]

mastiz@chromium.org changed reviewers:
+ baxley@chromium.org

[mastiz, 2017-03-21 13:48:39]

baxley@chromium.org: Please review changes in 

ios/chrome/test

[Mathieu, 2017-03-21 14:00:34]

lgtm thanks

[baxley, 2017-03-21 14:22:30]

On 2017/03/21 13:48:39, mastiz wrote:
> mailto:baxley@chromium.org: Please review changes in 
> 
> ios/chrome/test

LGTM

[commit-bot: I haz the power, 2017-03-21 14:23:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 14:23:33]

Dry run: This issue passed the CQ dry run.

[mastiz, 2017-03-21 14:28:00]

The CQ bit was checked by mastiz@chromium.org

[commit-bot: I haz the power, 2017-03-21 14:28:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 14:37:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 14:37:26]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mastiz, 2017-03-21 14:43:42]

mastiz@chromium.org changed reviewers:
+ asvitkine@chromium.org

[mastiz, 2017-03-21 14:43:43]

asvitkine@: adding you as reviewer due to:

You need LGTM from owners of depends-on paths in DEPS that were modified in this
CL:
    '+ui/gfx',

Suggested missing target path OWNERS:
    asvitkine@chromium.org

[Alexei Svitkine (slow), 2017-03-21 15:06:27]

lgtm

[mastiz, 2017-03-21 15:09:07]

The CQ bit was checked by mastiz@chromium.org

[commit-bot: I haz the power, 2017-03-21 15:09:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 15:20:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490108947548530,
"parent_rev": "33d8074e449407ac84ad0e6f3ea7ab3dbda19f28", "commit_rev":
"a31cd7215e84eee41286dc7f08020c740515ebe5"}

[commit-bot: I haz the power, 2017-03-21 15:20:45]

Description was changed from

==========
Move iOS image_fetcher::ImageDecoder to layered component

In general, ImageDecoder is not specific to suggestions and hence the
code does not belong ios/chrome/browser/suggestions.

In particular, we do this to avoid a dependency cycle in a future CL,
due to the integration of ImageFetcher in FaviconService, causing:
ERROR Dependency cycle:
  //ios/chrome/browser/sync:sync ->
  //ios/chrome/browser/bookmarks:bookmarks ->
  //ios/chrome/browser/favicon:favicon ->
  //ios/chrome/browser/suggestions:suggestions ->
  //ios/chrome/browser/sync:sync

BUG=644102,624761
==========

to

==========
Move iOS image_fetcher::ImageDecoder to layered component

In general, ImageDecoder is not specific to suggestions and hence the
code does not belong ios/chrome/browser/suggestions.

In particular, we do this to avoid a dependency cycle in a future CL,
due to the integration of ImageFetcher in FaviconService, causing:
ERROR Dependency cycle:
  //ios/chrome/browser/sync:sync ->
  //ios/chrome/browser/bookmarks:bookmarks ->
  //ios/chrome/browser/favicon:favicon ->
  //ios/chrome/browser/suggestions:suggestions ->
  //ios/chrome/browser/sync:sync

BUG=644102,624761

Review-Url: https://codereview.chromium.org/2762063003
Cr-Commit-Position: refs/heads/master@{#458419}
Committed:
https://chromium.googlesource.com/chromium/src/+/a31cd7215e84eee41286dc7f0802...
==========

[commit-bot: I haz the power, 2017-03-21 15:20:47]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a31cd7215e84eee41286dc7f0802...