Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 2761303002: Move common ImageFetcher component files to core/ (Closed)

Created:
3 years, 9 months ago by mastiz
Modified:
3 years, 9 months ago
Reviewers:
Marc Treib, sdefresne
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, samarth+watch_chromium.org, ntp-dev+reviews_chromium.org, pkl (ping after 24h if needed), donnd+watch_chromium.org, ios-reviews+chrome_chromium.org, jfweitz+watch_chromium.org, noyau+watch_chromium.org, Jered, oshima+watch_chromium.org, kmadhusu+watch_chromium.org, marq+watch_chromium.org, David Black, sdefresne+watch_chromium.org, davemoore+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move common ImageFetcher component files to core/ Let's follow the directory structure of layered components. TBR=mathp@chromium.org,sdefresne@chromium.org,jam@chromium.org BUG=624761 Review-Url: https://codereview.chromium.org/2761303002 Cr-Commit-Position: refs/heads/master@{#458461} Committed: https://chromium.googlesource.com/chromium/src/+/f4d088af9db25dfb569645655da829c28f84ee52

Patch Set 1 #

Patch Set 2 : Nit. #

Total comments: 2

Patch Set 3 : Minor change: remove semicolon. #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -1019 lines) Patch
M chrome/browser/android/logo_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/hats/hats_notification_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/hats/hats_notification_controller_unittest.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ntp_snippets/content_suggestions_service_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ntp_tiles/chrome_most_visited_sites_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/instant_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/suggestions/image_decoder_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/suggestions/image_fetcher_impl_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/search/suggestions/suggestions_service_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/search/thumbnail_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp_tiles_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D components/image_fetcher/BUILD.gn View 1 chunk +0 lines, -40 lines 0 comments Download
A + components/image_fetcher/core/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/image_fetcher/core/image_data_fetcher.h View 4 chunks +4 lines, -5 lines 0 comments Download
A + components/image_fetcher/core/image_data_fetcher.cc View 2 chunks +2 lines, -3 lines 0 comments Download
A + components/image_fetcher/core/image_data_fetcher_unittest.cc View 3 chunks +5 lines, -7 lines 0 comments Download
A + components/image_fetcher/core/image_decoder.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/image_fetcher/core/image_fetcher.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/image_fetcher/core/image_fetcher_delegate.h View 1 2 3 chunks +5 lines, -6 lines 0 comments Download
A + components/image_fetcher/core/image_fetcher_impl.h View 4 chunks +8 lines, -9 lines 0 comments Download
A + components/image_fetcher/core/image_fetcher_impl.cc View 4 chunks +7 lines, -8 lines 0 comments Download
A + components/image_fetcher/core/request_metadata.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/image_fetcher/core/request_metadata.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/image_fetcher/core/request_metadata_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D components/image_fetcher/image_data_fetcher.h View 1 chunk +0 lines, -84 lines 0 comments Download
D components/image_fetcher/image_data_fetcher.cc View 1 chunk +0 lines, -104 lines 0 comments Download
D components/image_fetcher/image_data_fetcher_unittest.cc View 1 chunk +0 lines, -206 lines 0 comments Download
D components/image_fetcher/image_decoder.h View 1 chunk +0 lines, -46 lines 0 comments Download
D components/image_fetcher/image_fetcher.h View 1 chunk +0 lines, -70 lines 0 comments Download
D components/image_fetcher/image_fetcher_delegate.h View 1 chunk +0 lines, -43 lines 0 comments Download
D components/image_fetcher/image_fetcher_impl.h View 1 chunk +0 lines, -108 lines 0 comments Download
D components/image_fetcher/image_fetcher_impl.cc View 1 chunk +0 lines, -111 lines 0 comments Download
M components/image_fetcher/ios/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/image_fetcher/ios/ios_image_data_fetcher_wrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M components/image_fetcher/ios/ios_image_decoder_impl.h View 1 chunk +1 line, -1 line 0 comments Download
D components/image_fetcher/request_metadata.h View 1 chunk +0 lines, -34 lines 0 comments Download
D components/image_fetcher/request_metadata.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D components/image_fetcher/request_metadata_unittest.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M components/ntp_snippets/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestions_provider_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_snippets/remote/remote_suggestions_provider_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/ntp_tiles/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/ntp_tiles/icon_cacher_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_tiles/icon_cacher_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/suggestions/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/suggestions/image_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/suggestions/image_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/suggestions/image_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ntp_snippets/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/ntp_tiles/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ntp_tiles/ios_most_visited_sites_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/suggestions/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/suggestions/suggestions_service_factory.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (10 generated)
mastiz
treib@: let me know whether this is desirable and whether there's some automated tool to ...
3 years, 9 months ago (2017-03-21 14:19:54 UTC) #2
Marc Treib
lgtm Yup, following the layered component structure definitely makes sense. No, I don't know of ...
3 years, 9 months ago (2017-03-21 14:40:04 UTC) #5
mastiz
Thanks. https://codereview.chromium.org/2761303002/diff/20001/components/image_fetcher/core/image_fetcher_delegate.h File components/image_fetcher/core/image_fetcher_delegate.h (right): https://codereview.chromium.org/2761303002/diff/20001/components/image_fetcher/core/image_fetcher_delegate.h#newcode27 components/image_fetcher/core/image_fetcher_delegate.h:27: const std::string& data){}; On 2017/03/21 14:40:04, Marc Treib ...
3 years, 9 months ago (2017-03-21 14:47:57 UTC) #6
mastiz
mathp@, sdefresne@ ,jam@: TBR-ing due to trivial include updates.
3 years, 9 months ago (2017-03-21 16:34:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761303002/60001
3 years, 9 months ago (2017-03-21 16:35:50 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/f4d088af9db25dfb569645655da829c28f84ee52
3 years, 9 months ago (2017-03-21 17:42:31 UTC) #15
sdefresne
3 years, 9 months ago (2017-03-22 09:48:26 UTC) #17
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698