cc : Delete target id and content target id from transform nodes

cc : Delete target id and content target id from transform nodes

They were used in computation of visible rects, but now they are not.

BUG=703818
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2762043005
Cr-Commit-Position: refs/heads/master@{#458894}
Committed: https://chromium.googlesource.com/chromium/src/+/f7a8e76c2a53d147b214c67167661e7760d9d5f3

[jaydasika, 2017-03-21 21:23:35]

Description was changed from

==========
cc : Delete target id and content target id from transform nodes

They were used in computation of visible rects, but now they are not.

BUG=703818
==========

to

==========
cc : Delete target id and content target id from transform nodes

They were used in computation of visible rects, but now they are not.

BUG=703818
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[jaydasika, 2017-03-21 21:25:54]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, weiliangc@chromium.org

[jaydasika, 2017-03-21 21:25:55]

PTAL

https://codereview.chromium.org/2762043005/diff/1/cc/trees/draw_property_util...
File cc/trees/draw_property_utils.cc (left):

https://codereview.chromium.org/2762043005/diff/1/cc/trees/draw_property_util...
cc/trees/draw_property_utils.cc:28: namespace {
I don't see any reason to have a separate namespace here. If there is a reason
for it, let me know, I will add it back.

[weiliangc, 2017-03-21 21:34:57]

https://codereview.chromium.org/2762043005/diff/1/cc/trees/draw_property_util...
File cc/trees/draw_property_utils.cc (left):

https://codereview.chromium.org/2762043005/diff/1/cc/trees/draw_property_util...
cc/trees/draw_property_utils.cc:28: namespace {
On 2017/03/21 at 21:25:55, jaydasika wrote:
> I don't see any reason to have a separate namespace here. If there is a reason
for it, let me know, I will add it back.

It is used since these are local helper functions.
https://google.github.io/styleguide/cppguide.html#Unnamed_Namespaces_and_Stat...

[jaydasika, 2017-03-21 22:05:37]

https://codereview.chromium.org/2762043005/diff/1/cc/trees/draw_property_util...
File cc/trees/draw_property_utils.cc (left):

https://codereview.chromium.org/2762043005/diff/1/cc/trees/draw_property_util...
cc/trees/draw_property_utils.cc:28: namespace {
On 2017/03/21 21:34:57, weiliangc wrote:
> On 2017/03/21 at 21:25:55, jaydasika wrote:
> > I don't see any reason to have a separate namespace here. If there is a
reason
> for it, let me know, I will add it back.
> 
> It is used since these are local helper functions.
>
https://google.github.io/styleguide/cppguide.html#Unnamed_Namespaces_and_Stat...

It says either make the functions static OR put them in a unnamed namespace. We
seem to be doing both. But, it does make sense to group them together, so added
back the namespace. Also, there are many more functions in this file that are
local to this file, added them also.

[weiliangc, 2017-03-22 17:59:30]

LGTM

[jaydasika, 2017-03-22 18:08:31]

The CQ bit was checked by jaydasika@chromium.org

[commit-bot: I haz the power, 2017-03-22 18:09:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 18:23:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 18:23:49]

Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jaydasika, 2017-03-22 18:42:38]

Description was changed from

==========
cc : Delete target id and content target id from transform nodes

They were used in computation of visible rects, but now they are not.

BUG=703818
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc : Delete target id and content target id from transform nodes

They were used in computation of visible rects, but now they are not.

BUG=703818
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[jaydasika, 2017-03-22 18:43:00]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 18:43:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jaydasika, 2017-03-22 18:44:34]

jaydasika@chromium.org changed reviewers:
+ chrishtr@chromium.org, pdr@chromium.org

[jaydasika, 2017-03-22 18:44:35]

+ pdr / chrishtr for blink (more deprecated fields)

[chrishtr, 2017-03-22 18:47:26]

lgtm

[commit-bot: I haz the power, 2017-03-22 22:06:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 22:06:37]

Dry run: This issue passed the CQ dry run.

[jaydasika, 2017-03-22 22:08:41]

The CQ bit was checked by jaydasika@chromium.org

[jaydasika, 2017-03-22 22:08:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
weiliangc@chromium.org
Link to the patchset: https://codereview.chromium.org/2762043005/#ps40001
(title: "blink changes")

[commit-bot: I haz the power, 2017-03-22 22:09:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 22:15:40]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490220521020500,
"parent_rev": "03c41c3afff86bdc441eb093749f4b2a4f6056b0", "commit_rev":
"f7a8e76c2a53d147b214c67167661e7760d9d5f3"}

[commit-bot: I haz the power, 2017-03-22 22:16:29]

Description was changed from

==========
cc : Delete target id and content target id from transform nodes

They were used in computation of visible rects, but now they are not.

BUG=703818
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
cc : Delete target id and content target id from transform nodes

They were used in computation of visible rects, but now they are not.

BUG=703818
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2762043005
Cr-Commit-Position: refs/heads/master@{#458894}
Committed:
https://chromium.googlesource.com/chromium/src/+/f7a8e76c2a53d147b214c6716766...
==========

[commit-bot: I haz the power, 2017-03-22 22:16:30]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f7a8e76c2a53d147b214c6716766...