Chromium Code Reviews
Help | Chromium Project | Sign in
(7)

Issue 2761963002: CANCELLED Merge SelectionAdjuster into VisibleSelection part 1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 days, 18 hours ago by Xiaocheng
Modified:
17 hours, 46 minutes ago
Reviewers:
tkent, yoichio, yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

CANCELLED Merge SelectionAdjuster into VisibleSelection part 1 This patch unpacks the static member functions from SelectionAdjuster, and stops them from modifying members of VisibleSelection, so that VisibleSelection is made closer to being immutable. A follow-up patch will move everthing in SelectionAdjuster.h/cpp to VisibleSelection.cpp since it's only used by VisibleSelection. BUG=660320 TEST=n/a; no behavior change

Patch Set 1 #

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -49 lines) Patch
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionAdjuster.h View 1 chunk +8 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp View 1 2 chunks +27 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 1 chunk +9 lines, -1 line 0 comments Download
Commit queue not available (can’t edit this change).

Dependent Patchsets:

Messages

Total messages: 16 (12 generated)
Xiaocheng
PTAL.
2 days, 18 hours ago (2017-03-20 22:04:22 UTC) #4
Xiaocheng
+tkent, yoichio
2 days, 12 hours ago (2017-03-21 03:48:45 UTC) #13
yosin_UTC9
I would like to do opposite. Move code out from VisibleSelection.cpp to SelectionAdjuster.cpp, may be ...
2 days, 12 hours ago (2017-03-21 04:00:32 UTC) #14
yoichio
2 days, 9 hours ago (2017-03-21 06:31:36 UTC) #15
I suggest something following for VisibelSelection immutability:
SelectionInDOMTree::Builder builder;
SelectionInDOMTree selection =  builder.collpase().build();
VisibleSelection vs =
SelectionVisibleAdjuster::createVisibleSelection(selection);
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d1a128a62