CANCELLED Merge SelectionAdjuster into VisibleSelection part 1

CANCELLED Merge SelectionAdjuster into VisibleSelection part 1

This patch unpacks the static member functions from SelectionAdjuster,
and stops them from modifying members of VisibleSelection, so that
VisibleSelection is made closer to being immutable.

A follow-up patch will move everthing in SelectionAdjuster.h/cpp
to VisibleSelection.cpp since it's only used by VisibleSelection.

BUG=660320
TEST=n/a; no behavior change

[Xiaocheng, 2017-03-20 22:04:11]

Description was changed from

==========
Merge SelectionAdjuster into VisibleSelection part 1

BUG=660320
==========

to

==========
Merge SelectionAdjuster into VisibleSelection part 1

This patch unpacks the static member functions from SelectionAdjuster,
and stops them from modifying members of VisibleSelection, so that
VisibleSelection is made closer to being immutable.

A follow-up patch will move everthing in SelectionAdjuster.h/cpp
to VisibleSelection.cpp since it's only used by VisibleSelection.

BUG=660320
TEST=n/a; no behavior change
==========

[Xiaocheng, 2017-03-20 22:04:11]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-03-20 22:04:15]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[Xiaocheng, 2017-03-20 22:04:22]

PTAL.

[commit-bot: I haz the power, 2017-03-20 22:05:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 23:20:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 23:20:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xiaocheng, 2017-03-20 23:25:40]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 23:26:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 01:58:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 01:58:45]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-03-21 03:48:45]

xiaochengh@chromium.org changed reviewers:
+ tkent@chromium.org, yoichio@chromium.org

[Xiaocheng, 2017-03-21 03:48:45]

+tkent, yoichio

[yosin_UTC9, 2017-03-21 04:00:32]

I would like to do opposite.
Move code out from VisibleSelection.cpp to SelectionAdjuster.cpp, may be we want
to rename this to SelectionUtilities.cpp, like what we did for
VisibleSeleciton.cpp.

There is similar selection adjustment in [1] which adjust range inside BODY.

https://codereview.chromium.org/2753193002#msg17 Editing: Indent command: Do not
insert BLOCKQUOTE under the root HTML element.

[yoichio, 2017-03-21 06:31:36]

I suggest something following for VisibelSelection immutability:
SelectionInDOMTree::Builder builder;
SelectionInDOMTree selection =  builder.collpase().build();
VisibleSelection vs =
SelectionVisibleAdjuster::createVisibleSelection(selection);

[Xiaocheng, 2017-03-22 22:37:40]

Description was changed from

==========
Merge SelectionAdjuster into VisibleSelection part 1

This patch unpacks the static member functions from SelectionAdjuster,
and stops them from modifying members of VisibleSelection, so that
VisibleSelection is made closer to being immutable.

A follow-up patch will move everthing in SelectionAdjuster.h/cpp
to VisibleSelection.cpp since it's only used by VisibleSelection.

BUG=660320
TEST=n/a; no behavior change
==========

to

==========
CANCELLED Merge SelectionAdjuster into VisibleSelection part 1

This patch unpacks the static member functions from SelectionAdjuster,
and stops them from modifying members of VisibleSelection, so that
VisibleSelection is made closer to being immutable.

A follow-up patch will move everthing in SelectionAdjuster.h/cpp
to VisibleSelection.cpp since it's only used by VisibleSelection.

BUG=660320
TEST=n/a; no behavior change
==========