Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2759943004: CANCELLED Merge SelectionAdjuster into VisibleSelection part 2 (Closed)

Created:
3 years, 9 months ago by Xiaocheng
Modified:
3 years, 9 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

CANCELLED Merge SelectionAdjuster into VisibleSelection part 2 This is the follow-up patch of http://crrev.com/2761963002 that moves everything in SelectionAdjuster.h/cpp to VisibleSelection.cpp. BUG=660320 TEST=n/a; no behavior change

Patch Set 1 #

Patch Set 2 : Mon Mar 20 13:42:53 PDT 2017 #

Patch Set 3 : Mon Mar 20 15:10:04 PDT 2017 #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -234 lines) Patch
M third_party/WebKit/Source/core/editing/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/editing/SelectionAdjuster.h View 1 2 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp View 1 2 3 1 chunk +0 lines, -206 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionEditor.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 1 2 3 2 chunks +173 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (10 generated)
Xiaocheng
PTAL.
3 years, 9 months ago (2017-03-20 22:11:57 UTC) #6
yosin_UTC9
3 years, 9 months ago (2017-03-22 05:24:53 UTC) #11
On 2017/03/20 at 22:11:57, xiaochengh wrote:
> PTAL.

I would like to keep "SelectionAdjuster.cpp" and make "VisibleSelection.cpp" as
small as "VisiblePosition.cpp"

Powered by Google App Engine
This is Rietveld 408576698