Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 2761703002: [turbofan] Properly handle IfException projections on JSForInNext. (Closed)

Created:
3 years, 9 months ago by Benedikt Meurer
Modified:
3 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly handle IfException projections on JSForInNext. Don't ignore IfException (and IfSuccess) projections on JSForInNext nodes during JSTypedLowering::ReduceJSForInNext, but instead rewrire the IfException projection to the ForInFilter stub call, which can throw exceptions in case of proxies. R=yangguo@chromium.org BUG=v8:6121 Review-Url: https://codereview.chromium.org/2761703002 Cr-Commit-Position: refs/heads/master@{#43925} Committed: https://chromium.googlesource.com/v8/v8/+/a93e5221d8f1187d3401e0afa232089736200dbe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +12 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-6121.js View 1 chunk +23 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
Benedikt Meurer
3 years, 9 months ago (2017-03-20 06:04:23 UTC) #1
Benedikt Meurer
Hey Yang, Here's a simple monday morning for..in fix. Please take a look. Thanks, Benedikt
3 years, 9 months ago (2017-03-20 06:04:52 UTC) #4
Yang
On 2017/03/20 06:04:52, Benedikt Meurer wrote: > Hey Yang, > > Here's a simple monday ...
3 years, 9 months ago (2017-03-20 06:14:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761703002/1
3 years, 9 months ago (2017-03-20 06:19:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/a93e5221d8f1187d3401e0afa232089736200dbe
3 years, 9 months ago (2017-03-20 06:32:38 UTC) #11
RE66
On 2017/03/20 06:32:38, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 9 months ago (2017-03-20 13:16:59 UTC) #12
Benedikt Meurer
3 years, 9 months ago (2017-03-20 13:19:19 UTC) #13
Message was sent while issue was closed.
On 2017/03/20 13:16:59, RE66 wrote:
> On 2017/03/20 06:32:38, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
https://chromium.googlesource.com/v8/v8/+/a93e5221d8f1187d3401e0afa2320897362...
> 
> the "if_false0" is not used

It's being used for the Merge.

Powered by Google App Engine
This is Rietveld 408576698