Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2763533002: [WIP] JSForInLowering and JSForInHasOwnProperty.

Created:
3 years, 9 months ago by Benedikt Meurer
Modified:
3 years, 9 months ago
Reviewers:
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[WIP] JSForInLowering and JSForInHasOwnProperty.

Patch Set 1 #

Patch Set 2 : Call Object.prototype.hasOwnProperty with correct context. #

Patch Set 3 : Fixes. #

Patch Set 4 : Hack around the issue with indices not being available always. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+603 lines, -98 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/access-builder.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 1 2 2 chunks +104 lines, -0 lines 0 comments Download
M src/compiler/js-call-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 2 chunks +33 lines, -0 lines 0 comments Download
A src/compiler/js-for-in-lowering.h View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
A src/compiler/js-for-in-lowering.cc View 1 2 3 1 chunk +305 lines, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 2 1 chunk +10 lines, -6 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 2 1 chunk +24 lines, -2 lines 0 comments Download
M src/compiler/js-operator.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-operator.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +0 lines, -88 lines 0 comments Download
M src/compiler/opcodes.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/operator-properties.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 2 2 chunks +12 lines, -1 line 0 comments Download
M src/compiler/types.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 2 2 chunks +14 lines, -0 lines 0 comments Download
M src/objects.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (16 generated)
Benedikt Meurer
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-20 06:44:35 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763533002/1
3 years, 9 months ago (2017-03-20 06:44:37 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-20 07:01:47 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/builds/2735) v8_linux_verify_csa_rel_ng_triggered on ...
3 years, 9 months ago (2017-03-20 07:01:48 UTC) #4
Benedikt Meurer
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-20 07:38:25 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763533002/20001
3 years, 9 months ago (2017-03-20 07:38:29 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-20 08:12:09 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 9 months ago (2017-03-20 08:12:10 UTC) #8
Benedikt Meurer
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-20 10:55:35 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763533002/40001
3 years, 9 months ago (2017-03-20 10:55:42 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-20 11:15:03 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_ng/builds/2828) v8_linux64_verify_csa_rel_ng_triggered on ...
3 years, 9 months ago (2017-03-20 11:15:04 UTC) #12
Benedikt Meurer
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-20 12:24:51 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763533002/60001
3 years, 9 months ago (2017-03-20 12:25:08 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-20 12:51:57 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 12:51:58 UTC) #16 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698