[scheduler] CPUTimeBudgetPool: Require a minimal level of budget to run

[scheduler] CPUTimeBudgetPool: Require a minimal level of budget to run

Another refactoring for wakeup-based budget throttling.
Add an option to require a certain minimal budget level to unblock
CPUTimeBudgetPool. This is required to prevent situation when
wakeup happens and TimeBudgetPool does not have budget to run tasks.

BUG=699541
Review-Url: https://codereview.chromium.org/2761503002
Cr-Commit-Position: refs/heads/master@{#458428}
Committed: https://chromium.googlesource.com/chromium/src/+/ba7dda2a1174b01ffa47e1de8afd38501d307f1b

[altimin, 2017-03-17 18:55:47]

altimin@chromium.org changed reviewers:
+ alexclarke@chromium.org, skyostil@chromium.org

[altimin, 2017-03-17 18:55:47]

PTAL

[alex clarke (OOO till 29th), 2017-03-20 09:03:03]

https://codereview.chromium.org/2761503002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/scheduler/renderer/budget_pool.cc
(right):

https://codereview.chromium.org/2761503002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scheduler/renderer/budget_pool.cc:72:
min_budget_level_to_run_ = min_budget_level_to_run;
Do we expect this to get called more than once during start up?  It can change
the result of GetNextAllowedRunTime() so people might expect it to have effect
immediately?

https://codereview.chromium.org/2761503002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/scheduler/renderer/budget_pool.h
(right):

https://codereview.chromium.org/2761503002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scheduler/renderer/budget_pool.h:107: // It
still can run tasks when budget is positive but less than this level.
This sentence seems to state the opposite of the previous one, could you perhaps
elaborate a bit?

https://codereview.chromium.org/2761503002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scheduler/renderer/budget_pool.h:170: // Note
that this is not the guarantee that every task will run
... is not _a_ guarantee that ...

https://codereview.chromium.org/2761503002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scheduler/renderer/budget_pool.h:174: //
Minimal budget required to be accumulated after queue is blocked
Could you please reword? I found this sentence confusing.   s/Minimal/Minimum

[altimin, 2017-03-20 15:21:08]

PTAL

https://codereview.chromium.org/2761503002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/scheduler/renderer/budget_pool.cc
(right):

https://codereview.chromium.org/2761503002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scheduler/renderer/budget_pool.cc:72:
min_budget_level_to_run_ = min_budget_level_to_run;
On 2017/03/20 09:03:03, alex clarke wrote:
> Do we expect this to get called more than once during start up?  It can change
> the result of GetNextAllowedRunTime() so people might expect it to have effect
> immediately?

Added a comment if the header file.

https://codereview.chromium.org/2761503002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/scheduler/renderer/budget_pool.h
(right):

https://codereview.chromium.org/2761503002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scheduler/renderer/budget_pool.h:107: // It
still can run tasks when budget is positive but less than this level.
On 2017/03/20 09:03:03, alex clarke wrote:
> This sentence seems to state the opposite of the previous one, could you
perhaps
> elaborate a bit?

Done.

https://codereview.chromium.org/2761503002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scheduler/renderer/budget_pool.h:170: // Note
that this is not the guarantee that every task will run
On 2017/03/20 09:03:03, alex clarke wrote:
> ... is not _a_ guarantee that ...

Done.

https://codereview.chromium.org/2761503002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scheduler/renderer/budget_pool.h:174: //
Minimal budget required to be accumulated after queue is blocked
On 2017/03/20 09:03:03, alex clarke wrote:
> Could you please reword? I found this sentence confusing.   s/Minimal/Minimum

Done.

[alex clarke (OOO till 29th), 2017-03-21 08:35:21]

lgtm

[Sami, 2017-03-21 11:32:56]

lgtm

https://codereview.chromium.org/2761503002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/scheduler/renderer/budget_pool.cc
(right):

https://codereview.chromium.org/2761503002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/renderer/budget_pool.cc:9: #include
<fstream>   // FIXME
Remove?

[altimin, 2017-03-21 14:33:28]

The CQ bit was checked by altimin@chromium.org

[altimin, 2017-03-21 14:33:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org, alexclarke@chromium.org
Link to the patchset: https://codereview.chromium.org/2761503002/#ps40001
(title: "Remove #include <*stream>")

[commit-bot: I haz the power, 2017-03-21 14:33:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 16:03:23]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490106808595430,
"parent_rev": "378b4e8a2660f9dfc74abdc2b04f3ffcbdf93671", "commit_rev":
"ba7dda2a1174b01ffa47e1de8afd38501d307f1b"}

[commit-bot: I haz the power, 2017-03-21 16:04:06]

Description was changed from

==========
[scheduler] CPUTimeBudgetPool: Require a minimal level of budget to run

Another refactoring for wakeup-based budget throttling.
Add an option to require a certain minimal budget level to unblock
CPUTimeBudgetPool. This is required to prevent situation when
wakeup happens and TimeBudgetPool does not have budget to run tasks.

BUG=699541
==========

to

==========
[scheduler] CPUTimeBudgetPool: Require a minimal level of budget to run

Another refactoring for wakeup-based budget throttling.
Add an option to require a certain minimal budget level to unblock
CPUTimeBudgetPool. This is required to prevent situation when
wakeup happens and TimeBudgetPool does not have budget to run tasks.

BUG=699541

Review-Url: https://codereview.chromium.org/2761503002
Cr-Commit-Position: refs/heads/master@{#458428}
Committed:
https://chromium.googlesource.com/chromium/src/+/ba7dda2a1174b01ffa47e1de8afd...
==========

[commit-bot: I haz the power, 2017-03-21 16:04:09]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ba7dda2a1174b01ffa47e1de8afd...