Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/budget_pool_unittest.cc

Issue 2761503002: [scheduler] CPUTimeBudgetPool: Require a minimal level of budget to run (Closed)
Patch Set: Remove #include <*stream> Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/budget_pool_unittest.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/budget_pool_unittest.cc b/third_party/WebKit/Source/platform/scheduler/renderer/budget_pool_unittest.cc
index e395fae09b2ef1e1644c38e1eeda4af6ae8191a8..a02778d4a2388e0e17f4f089aadf983a1bf8ada2 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/budget_pool_unittest.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/budget_pool_unittest.cc
@@ -56,8 +56,8 @@ class BudgetPoolTest : public testing::Test {
};
TEST_F(BudgetPoolTest, CPUTimeBudgetPool) {
- CPUTimeBudgetPool* pool = task_queue_throttler_->CreateCPUTimeBudgetPool(
- "test", base::nullopt, base::nullopt);
+ CPUTimeBudgetPool* pool =
+ task_queue_throttler_->CreateCPUTimeBudgetPool("test");
base::TimeTicks time_zero = clock_->NowTicks();
@@ -90,5 +90,40 @@ TEST_F(BudgetPoolTest, CPUTimeBudgetPool) {
pool->Close();
}
+TEST_F(BudgetPoolTest, CPUTimeBudgetPoolMinBudgetLevelToRun) {
+ CPUTimeBudgetPool* pool =
+ task_queue_throttler_->CreateCPUTimeBudgetPool("test");
+
+ base::TimeTicks time_zero = clock_->NowTicks();
+
+ pool->SetMinBudgetLevelToRun(time_zero,
+ base::TimeDelta::FromMilliseconds(10));
+ pool->SetTimeBudgetRecoveryRate(time_zero, 0.1);
+
+ EXPECT_TRUE(pool->HasEnoughBudgetToRun(time_zero));
+ EXPECT_EQ(time_zero, pool->GetNextAllowedRunTime());
+
+ pool->RecordTaskRunTime(time_zero,
+ time_zero + base::TimeDelta::FromMilliseconds(10));
+ EXPECT_FALSE(pool->HasEnoughBudgetToRun(
+ time_zero + base::TimeDelta::FromMilliseconds(15)));
+ EXPECT_FALSE(pool->HasEnoughBudgetToRun(
+ time_zero + base::TimeDelta::FromMilliseconds(150)));
+ // We need to wait extra 100ms to get budget of 10ms.
+ EXPECT_EQ(time_zero + base::TimeDelta::FromMilliseconds(200),
+ pool->GetNextAllowedRunTime());
+
+ pool->RecordTaskRunTime(time_zero + base::TimeDelta::FromMilliseconds(200),
+ time_zero + base::TimeDelta::FromMilliseconds(205));
+ // We can run when budget is non-negative even when it less than 10ms.
+ EXPECT_EQ(time_zero + base::TimeDelta::FromMilliseconds(205),
+ pool->GetNextAllowedRunTime());
+
+ pool->RecordTaskRunTime(time_zero + base::TimeDelta::FromMilliseconds(205),
+ time_zero + base::TimeDelta::FromMilliseconds(215));
+ EXPECT_EQ(time_zero + base::TimeDelta::FromMilliseconds(350),
+ pool->GetNextAllowedRunTime());
+}
+
} // namespace scheduler
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698