Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2761363004: Remove seldom used tab_swtiching test cases (Closed)

Created:
3 years, 9 months ago by vovoy
Modified:
3 years, 9 months ago
Reviewers:
nednguyen, deanliao, perezju
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove seldom used tab_swtiching test cases Only keep tab_switching.typical_25 and remove other seldom used cases to make it simpler to refactor tab_switching and to use the new multi-tab story BUG=689388 Review-Url: https://codereview.chromium.org/2761363004 Cr-Commit-Position: refs/heads/master@{#458780} Committed: https://chromium.googlesource.com/chromium/src/+/9312528ca1b2eae58054f057b94f5b6824a9a2b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2829 lines, -7534 lines) Patch
M testing/buildbot/chromium.perf.json View 2098 chunks +2102 lines, -5750 lines 0 comments Download
M testing/buildbot/chromium.perf.fyi.json View 504 chunks +727 lines, -1411 lines 0 comments Download
M tools/perf/benchmarks/tab_switching.py View 2 chunks +0 lines, -94 lines 0 comments Download
D tools/perf/page_sets/data/tough_energy_cases.json View 1 chunk +0 lines, -51 lines 0 comments Download
D tools/perf/page_sets/data/tough_energy_cases_000.wpr.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/tough_energy_cases_002.wpr.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/five_blank_pages.py View 1 chunk +0 lines, -23 lines 0 comments Download
D tools/perf/page_sets/tough_energy_cases.py View 1 chunk +0 lines, -129 lines 0 comments Download
D tools/perf/page_sets/tough_energy_cases/Biang-order.gif View Binary file 0 comments Download
D tools/perf/page_sets/tough_energy_cases/above-fold-animated-gif.html View 1 chunk +0 lines, -9 lines 0 comments Download
D tools/perf/page_sets/tough_energy_cases/below-fold-animated-gif.html View 1 chunk +0 lines, -11 lines 0 comments Download
D tools/perf/page_sets/tough_energy_cases/below-fold-flash.html View 1 chunk +0 lines, -22 lines 0 comments Download
D tools/perf/page_sets/tough_energy_cases/test.swf View Binary file 0 comments Download
D tools/perf/page_sets/tough_image_cases.py View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
vovoy
discussion on other review: https://codereview.chromium.org/2766533002/#msg13
3 years, 9 months ago (2017-03-22 08:32:53 UTC) #10
perezju
lgtm thanks for the cleanup!
3 years, 9 months ago (2017-03-22 09:45:03 UTC) #11
perezju
lgtm thanks for the cleanup!
3 years, 9 months ago (2017-03-22 09:45:03 UTC) #12
nednguyen
lgtm thanks!
3 years, 9 months ago (2017-03-22 12:19:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761363004/1
3 years, 9 months ago (2017-03-22 16:44:29 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 16:50:45 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9312528ca1b2eae58054f057b94f...

Powered by Google App Engine
This is Rietveld 408576698