[Home] Improve exit tab switcher animation

[Home] Improve exit tab switcher animation

This change improves the exit tab switcher animation and includes
the following:

- The toolbar animates the reverse of the enter animation.
- The timing of the tab movements has been unified to appear more
  smooth.
- Tab size in the tab switcher has been increased.

BUG=702717
Review-Url: https://codereview.chromium.org/2761273004
Cr-Commit-Position: refs/heads/master@{#458872}
Committed: https://chromium.googlesource.com/chromium/src/+/da4bc538cc6b36cf5246f3dfcca30562a43d4947

[mdjones, 2017-03-21 22:24:21]

mdjones@chromium.org changed reviewers:
+ dfalcantara@chromium.org, twellington@chromium.org

[mdjones, 2017-03-21 22:24:22]

ptal; video attached in bug.

[gone, 2017-03-22 01:53:50]

lgtm

https://codereview.chromium.org/2761273004/diff/20001/chrome/android/java/res...
File chrome/android/java/res/values/colors.xml (right):

https://codereview.chromium.org/2761273004/diff/20001/chrome/android/java/res...
chrome/android/java/res/values/colors.xml:31: <color
name="semi_opaque_black">#66000000</color>
I continue objecting to your putting these one-time colors in the common section
:P

[mdjones, 2017-03-22 15:57:05]

https://codereview.chromium.org/2761273004/diff/20001/chrome/android/java/res...
File chrome/android/java/res/values/colors.xml (right):

https://codereview.chromium.org/2761273004/diff/20001/chrome/android/java/res...
chrome/android/java/res/values/colors.xml:31: <color
name="semi_opaque_black">#66000000</color>
On 2017/03/22 01:53:50, dfalcantara (load balance plz) wrote:
> I continue objecting to your putting these one-time colors in the common
section
> :P

I could move these to the toolbar section. I figured if they were in the common
section, they are more likely to be reused.

[Theresa, 2017-03-22 16:00:31]

lgtm

[mdjones, 2017-03-22 17:54:56]

https://codereview.chromium.org/2761273004/diff/20001/chrome/android/java/res...
File chrome/android/java/res/values/colors.xml (right):

https://codereview.chromium.org/2761273004/diff/20001/chrome/android/java/res...
chrome/android/java/res/values/colors.xml:31: <color
name="semi_opaque_black">#66000000</color>
On 2017/03/22 01:53:50, dfalcantara (load balance plz) wrote:
> I continue objecting to your putting these one-time colors in the common
section
> :P

Renamed colors

[mdjones, 2017-03-22 18:01:49]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2017-03-22 18:01:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2761273004/#ps40001
(title: "color names")

[commit-bot: I haz the power, 2017-03-22 18:02:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 19:39:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 19:39:31]

Failed to apply patch for chrome/android/java/res/values/colors.xml:
While running git apply --index -p1;
  error: patch failed: chrome/android/java/res/values/colors.xml:27
  error: chrome/android/java/res/values/colors.xml: patch does not apply

Patch:       chrome/android/java/res/values/colors.xml
Index: chrome/android/java/res/values/colors.xml
diff --git a/chrome/android/java/res/values/colors.xml
b/chrome/android/java/res/values/colors.xml
index
d156c8747b6354e475ad771a0ab666437dc2deb9..9133a75528020b65b7738fa52ffb9e01dd094a43
100644
--- a/chrome/android/java/res/values/colors.xml
+++ b/chrome/android/java/res/values/colors.xml
@@ -27,7 +27,8 @@
     <color name="google_grey_600">#757575</color>
     <color name="google_grey_700">#616161</color>
     <color name="toolbar_shadow_color">#1d000000</color>
-    <color name="semi_opaque_white">#80ffffff</color>
+    <color name="white_alpha_50">#80ffffff</color>
+    <color name="black_alpha_40">#66000000</color>
     <color name="toolbar_light_tint">#A3000000</color>
     <color name="light_grey">#ccc</color>

[mdjones, 2017-03-22 19:52:44]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2017-03-22 19:52:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2761273004/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-22 19:53:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 20:58:31]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490212364300960,
"parent_rev": "bd09b2036a499ad0be4d31a51898c33d20252878", "commit_rev":
"da4bc538cc6b36cf5246f3dfcca30562a43d4947"}

[commit-bot: I haz the power, 2017-03-22 20:59:19]

Description was changed from

==========
[Home] Improve exit tab switcher animation

This change improves the exit tab switcher animation and includes
the following:

- The toolbar animates the reverse of the enter animation.
- The timing of the tab movements has been unified to appear more
  smooth.
- Tab size in the tab switcher has been increased.

BUG=702717
==========

to

==========
[Home] Improve exit tab switcher animation

This change improves the exit tab switcher animation and includes
the following:

- The toolbar animates the reverse of the enter animation.
- The timing of the tab movements has been unified to appear more
  smooth.
- Tab size in the tab switcher has been increased.

BUG=702717

Review-Url: https://codereview.chromium.org/2761273004
Cr-Commit-Position: refs/heads/master@{#458872}
Committed:
https://chromium.googlesource.com/chromium/src/+/da4bc538cc6b36cf5246f3dfcca3...
==========

[commit-bot: I haz the power, 2017-03-22 20:59:20]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/da4bc538cc6b36cf5246f3dfcca3...