Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4436)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimation.java

Issue 2761273004: [Home] Improve exit tab switcher animation (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimation.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimation.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimation.java
index 9c923c698aa6e17cc03f1d06099ef58950055ffb..acae0fd7cfd63c0beac270a126e0d9567a348096 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimation.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimation.java
@@ -80,10 +80,12 @@ public abstract class StackAnimation {
protected final float mBorderTopHeight;
protected final float mBorderTopOpaqueHeight;
protected final float mBorderLeftWidth;
+ protected final Stack mStack;
/**
* Protected constructor.
*
+ * @param stack The stack using the animations provided by this class.
* @param width The width of the layout in dp.
* @param height The height of the layout in dp.
* @param heightMinusBrowserControls The height of the layout minus the browser controls in dp.
@@ -91,9 +93,10 @@ public abstract class StackAnimation {
* @param borderFramePaddingTopOpaque The opaque top padding of the border frame in dp.
* @param borderFramePaddingLeft The left padding of the border frame in dp.
*/
- protected StackAnimation(float width, float height, float heightMinusBrowserControls,
- float borderFramePaddingTop, float borderFramePaddingTopOpaque,
- float borderFramePaddingLeft) {
+ protected StackAnimation(Stack stack, float width, float height,
+ float heightMinusBrowserControls, float borderFramePaddingTop,
+ float borderFramePaddingTopOpaque, float borderFramePaddingLeft) {
+ mStack = stack;
mWidth = width;
mHeight = height;
mHeightMinusBrowserControls = heightMinusBrowserControls;
@@ -107,6 +110,7 @@ public abstract class StackAnimation {
* The factory method that creates the particular factory method based on the orientation
* parameter.
*
+ * @param stack The stack of tabs being animated.
* @param width The width of the layout in dp.
* @param height The height of the layout in dp.
* @param heightMinusBrowserControls The height of the layout minus the browser controls in dp.
@@ -117,19 +121,21 @@ public abstract class StackAnimation {
* appropriate {@link StackAnimation}.
* @return The TabSwitcherAnimationFactory instance.
*/
- public static StackAnimation createAnimationFactory(float width, float height,
+ public static StackAnimation createAnimationFactory(Stack stack, float width, float height,
float heightMinusBrowserControls, float borderFramePaddingTop,
float borderFramePaddingTopOpaque, float borderFramePaddingLeft, int orientation) {
StackAnimation factory = null;
switch (orientation) {
case Orientation.LANDSCAPE:
- factory = new StackAnimationLandscape(width, height, heightMinusBrowserControls,
- borderFramePaddingTop, borderFramePaddingTopOpaque, borderFramePaddingLeft);
+ factory = new StackAnimationLandscape(stack, width, height,
+ heightMinusBrowserControls, borderFramePaddingTop,
+ borderFramePaddingTopOpaque, borderFramePaddingLeft);
break;
case Orientation.PORTRAIT:
default:
- factory = new StackAnimationPortrait(width, height, heightMinusBrowserControls,
- borderFramePaddingTop, borderFramePaddingTopOpaque, borderFramePaddingLeft);
+ factory = new StackAnimationPortrait(stack, width, height,
+ heightMinusBrowserControls, borderFramePaddingTop,
+ borderFramePaddingTopOpaque, borderFramePaddingLeft);
break;
}

Powered by Google App Engine
This is Rietveld 408576698