Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2761273003: Switching MediaStreamsManager from using AudioManager interface to AudioSystem one. (Closed)

Created:
3 years, 9 months ago by o1ka
Modified:
3 years, 9 months ago
CC:
audio-mojo-cl_google.com, chfremer+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, Max Morin, miu+watch_chromium.org, posciak+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Switching MediaStreamsManager from using AudioManager interface to AudioSystem one. BUG=672468 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2761273003 Cr-Commit-Position: refs/heads/master@{#458476} Committed: https://chromium.googlesource.com/chromium/src/+/4e2655ac5428e02f7aeb2051b0b43f1c961cbe95

Patch Set 1 #

Total comments: 1

Patch Set 2 : passing device descriptions by value #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -35 lines) Patch
M content/browser/renderer_host/media/media_devices_manager.h View 1 4 chunks +9 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/media_devices_manager.cc View 1 6 chunks +22 lines, -29 lines 0 comments Download
M content/browser/renderer_host/media/media_devices_manager_unittest.cc View 4 chunks +4 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/audio/audio_system.h View 1 3 chunks +9 lines, -0 lines 1 comment Download
M media/audio/audio_system_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/audio/audio_system_impl.cc View 1 2 chunks +30 lines, -0 lines 0 comments Download
M media/audio/audio_system_impl_unittest.cc View 1 6 chunks +91 lines, -0 lines 0 comments Download
M media/audio/mock_audio_manager.h View 4 chunks +9 lines, -0 lines 0 comments Download
M media/audio/mock_audio_manager.cc View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
o1ka
guidou@chromium.org: Please review changes in content/browser/renderer_host/media/ dalecurtis@chromium.org: Please review changes in media/audio thanks!
3 years, 9 months ago (2017-03-21 10:23:47 UTC) #5
Guido Urdaneta
content/browser/renderer_host/media lgtm
3 years, 9 months ago (2017-03-21 10:37:55 UTC) #7
Max Morin
https://codereview.chromium.org/2761273003/diff/1/media/audio/audio_system.h File media/audio/audio_system.h (right): https://codereview.chromium.org/2761273003/diff/1/media/audio/audio_system.h#newcode31 media/audio/audio_system.h:31: base::Callback<void(std::unique_ptr<AudioDeviceDescriptions>)>; Why is unique_ptr needed?
3 years, 9 months ago (2017-03-21 10:44:00 UTC) #8
o1ka
On 2017/03/21 10:44:00, Max Morin wrote: > https://codereview.chromium.org/2761273003/diff/1/media/audio/audio_system.h > File media/audio/audio_system.h (right): > > https://codereview.chromium.org/2761273003/diff/1/media/audio/audio_system.h#newcode31 ...
3 years, 9 months ago (2017-03-21 15:12:42 UTC) #13
DaleCurtis
lgtm
3 years, 9 months ago (2017-03-21 18:04:58 UTC) #16
o1ka
Thank you all!
3 years, 9 months ago (2017-03-21 18:10:20 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761273003/20001
3 years, 9 months ago (2017-03-21 18:10:45 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/4e2655ac5428e02f7aeb2051b0b43f1c961cbe95
3 years, 9 months ago (2017-03-21 18:18:05 UTC) #23
Guido Urdaneta
https://codereview.chromium.org/2761273003/diff/20001/media/audio/audio_system.h File media/audio/audio_system.h (right): https://codereview.chromium.org/2761273003/diff/20001/media/audio/audio_system.h#newcode62 media/audio/audio_system.h:62: OnDeviceDescriptionsCallback on_descriptions_cp, belated nit: you probably wanted |on_descriptions_cb| (instead ...
3 years, 9 months ago (2017-03-21 20:17:40 UTC) #24
o1ka
3 years, 9 months ago (2017-03-22 11:57:40 UTC) #25
Message was sent while issue was closed.
On 2017/03/21 20:17:40, Guido Urdaneta wrote:
>
https://codereview.chromium.org/2761273003/diff/20001/media/audio/audio_system.h
> File media/audio/audio_system.h (right):
> 
>
https://codereview.chromium.org/2761273003/diff/20001/media/audio/audio_syste...
> media/audio/audio_system.h:62: OnDeviceDescriptionsCallback
on_descriptions_cp,
> belated nit: you probably wanted |on_descriptions_cb| (instead of cp)

Right, I just flipped the letter upside-down :)
Thanks, will fix it in the next CL!

Powered by Google App Engine
This is Rietveld 408576698