Switching MediaStreamsManager from using AudioManager interface to AudioSystem one.

Switching MediaStreamsManager from using AudioManager interface to AudioSystem one.

BUG=672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2761273003
Cr-Commit-Position: refs/heads/master@{#458476}
Committed: https://chromium.googlesource.com/chromium/src/+/4e2655ac5428e02f7aeb2051b0b43f1c961cbe95

[o1ka, 2017-03-21 09:41:50]

Description was changed from

==========
Switching MediaStreamsManager from using AudioManager interface to AudioSystem
one.

BUG=672468
==========

to

==========
Switching MediaStreamsManager from using AudioManager interface to AudioSystem
one.

BUG=672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[o1ka, 2017-03-21 09:41:59]

The CQ bit was checked by olka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 09:42:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[o1ka, 2017-03-21 10:23:47]

olka@chromium.org changed reviewers:
+ dalecurtis@chromium.org, guidou@chromium.org

[o1ka, 2017-03-21 10:23:47]

guidou@chromium.org: Please review changes in 	
content/browser/renderer_host/media/

dalecurtis@chromium.org: Please review changes in 
media/audio

thanks!

[o1ka, 2017-03-21 10:25:30]

Description was changed from

==========
Switching MediaStreamsManager from using AudioManager interface to AudioSystem
one.

BUG=672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Switching MediaStreamsManager from using AudioManager interface to AudioSystem
one.

BUG=672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Guido Urdaneta, 2017-03-21 10:37:55]

content/browser/renderer_host/media lgtm

[Max Morin, 2017-03-21 10:44:00]

https://codereview.chromium.org/2761273003/diff/1/media/audio/audio_system.h
File media/audio/audio_system.h (right):

https://codereview.chromium.org/2761273003/diff/1/media/audio/audio_system.h#...
media/audio/audio_system.h:31:
base::Callback<void(std::unique_ptr<AudioDeviceDescriptions>)>;
Why is unique_ptr needed?

[commit-bot: I haz the power, 2017-03-21 11:08:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 11:08:43]

Dry run: This issue passed the CQ dry run.

[o1ka, 2017-03-21 15:11:55]

The CQ bit was checked by olka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 15:12:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[o1ka, 2017-03-21 15:12:42]

On 2017/03/21 10:44:00, Max Morin wrote:
> https://codereview.chromium.org/2761273003/diff/1/media/audio/audio_system.h
> File media/audio/audio_system.h (right):
> 
>
https://codereview.chromium.org/2761273003/diff/1/media/audio/audio_system.h#...
> media/audio/audio_system.h:31:
> base::Callback<void(std::unique_ptr<AudioDeviceDescriptions>)>;
> Why is unique_ptr needed?

not any more :) see ps2

[commit-bot: I haz the power, 2017-03-21 16:32:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 16:32:47]

Dry run: This issue passed the CQ dry run.

[DaleCurtis, 2017-03-21 18:04:58]

lgtm

[o1ka, 2017-03-21 18:10:02]

The CQ bit was checked by olka@chromium.org

[o1ka, 2017-03-21 18:10:03]

The patchset sent to the CQ was uploaded after l-g-t-m from guidou@chromium.org
Link to the patchset: https://codereview.chromium.org/2761273003/#ps20001
(title: "passing device descriptions by value")

[o1ka, 2017-03-21 18:10:20]

Thank you all!

[commit-bot: I haz the power, 2017-03-21 18:10:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 18:17:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490119802886910,
"parent_rev": "c2087acb00eee7960339a0be34ea27d6b20e1131", "commit_rev":
"4e2655ac5428e02f7aeb2051b0b43f1c961cbe95"}

[commit-bot: I haz the power, 2017-03-21 18:18:04]

Description was changed from

==========
Switching MediaStreamsManager from using AudioManager interface to AudioSystem
one.

BUG=672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Switching MediaStreamsManager from using AudioManager interface to AudioSystem
one.

BUG=672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2761273003
Cr-Commit-Position: refs/heads/master@{#458476}
Committed:
https://chromium.googlesource.com/chromium/src/+/4e2655ac5428e02f7aeb2051b0b4...
==========

[commit-bot: I haz the power, 2017-03-21 18:18:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4e2655ac5428e02f7aeb2051b0b4...

[Guido Urdaneta, 2017-03-21 20:17:40]

https://codereview.chromium.org/2761273003/diff/20001/media/audio/audio_system.h
File media/audio/audio_system.h (right):

https://codereview.chromium.org/2761273003/diff/20001/media/audio/audio_syste...
media/audio/audio_system.h:62: OnDeviceDescriptionsCallback on_descriptions_cp,
belated nit: you probably wanted |on_descriptions_cb| (instead of cp)

[o1ka, 2017-03-22 11:57:40]

On 2017/03/21 20:17:40, Guido Urdaneta wrote:
>
https://codereview.chromium.org/2761273003/diff/20001/media/audio/audio_system.h
> File media/audio/audio_system.h (right):
> 
>
https://codereview.chromium.org/2761273003/diff/20001/media/audio/audio_syste...
> media/audio/audio_system.h:62: OnDeviceDescriptionsCallback
on_descriptions_cp,
> belated nit: you probably wanted |on_descriptions_cb| (instead of cp)

Right, I just flipped the letter upside-down :)
Thanks, will fix it in the next CL!