Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: media/audio/audio_system_impl.cc

Issue 2761273003: Switching MediaStreamsManager from using AudioManager interface to AudioSystem one. (Closed)
Patch Set: passing device descriptions by value Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/audio/audio_system_impl.h" 5 #include "media/audio/audio_system_impl.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/single_thread_task_runner.h" 8 #include "base/single_thread_task_runner.h"
9 #include "base/task_runner_util.h" 9 #include "base/task_runner_util.h"
10 #include "media/audio/audio_device_description.h" 10 #include "media/audio/audio_device_description.h"
(...skipping 27 matching lines...) Expand all
38 // AudioManager::Get[Default]OutputStreamParameters() returns invalid 38 // AudioManager::Get[Default]OutputStreamParameters() returns invalid
39 // parameters if the device is not found. 39 // parameters if the device is not found.
40 if (!audio_manager->HasAudioOutputDevices()) 40 if (!audio_manager->HasAudioOutputDevices())
41 return AudioParameters(); 41 return AudioParameters();
42 42
43 return media::AudioDeviceDescription::IsDefaultDevice(device_id) 43 return media::AudioDeviceDescription::IsDefaultDevice(device_id)
44 ? audio_manager->GetDefaultOutputStreamParameters() 44 ? audio_manager->GetDefaultOutputStreamParameters()
45 : audio_manager->GetOutputStreamParameters(device_id); 45 : audio_manager->GetOutputStreamParameters(device_id);
46 } 46 }
47 47
48 AudioDeviceDescriptions GetDeviceDescriptionsOnDeviceThread(
49 AudioManager* audio_manager,
50 bool for_input) {
51 DCHECK(audio_manager->GetTaskRunner()->BelongsToCurrentThread());
52 AudioDeviceDescriptions descriptions;
53 if (for_input)
54 audio_manager->GetAudioInputDeviceDescriptions(&descriptions);
55 else
56 audio_manager->GetAudioOutputDeviceDescriptions(&descriptions);
57 return descriptions;
58 }
59
48 } // namespace 60 } // namespace
49 61
50 AudioSystemImpl::AudioSystemImpl(AudioManager* audio_manager) 62 AudioSystemImpl::AudioSystemImpl(AudioManager* audio_manager)
51 : audio_manager_(audio_manager) { 63 : audio_manager_(audio_manager) {
52 DCHECK(audio_manager_); 64 DCHECK(audio_manager_);
53 AudioSystem::SetInstance(this); 65 AudioSystem::SetInstance(this);
54 } 66 }
55 67
56 AudioSystemImpl::~AudioSystemImpl() { 68 AudioSystemImpl::~AudioSystemImpl() {
57 AudioSystem::ClearInstance(this); 69 AudioSystem::ClearInstance(this);
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 base::Bind(on_has_devices_cb, audio_manager_->HasAudioInputDevices())); 114 base::Bind(on_has_devices_cb, audio_manager_->HasAudioInputDevices()));
103 return; 115 return;
104 } 116 }
105 base::PostTaskAndReplyWithResult( 117 base::PostTaskAndReplyWithResult(
106 GetTaskRunner(), FROM_HERE, 118 GetTaskRunner(), FROM_HERE,
107 base::Bind(&AudioManager::HasAudioInputDevices, 119 base::Bind(&AudioManager::HasAudioInputDevices,
108 base::Unretained(audio_manager_)), 120 base::Unretained(audio_manager_)),
109 std::move(on_has_devices_cb)); 121 std::move(on_has_devices_cb));
110 } 122 }
111 123
124 void AudioSystemImpl::GetDeviceDescriptions(
125 OnDeviceDescriptionsCallback on_descriptions_cp,
126 bool for_input) {
127 if (GetTaskRunner()->BelongsToCurrentThread()) {
128 GetTaskRunner()->PostTask(
129 FROM_HERE, base::Bind(on_descriptions_cp,
130 base::Passed(GetDeviceDescriptionsOnDeviceThread(
131 audio_manager_, for_input))));
132 return;
133 }
134
135 base::PostTaskAndReplyWithResult(
136 GetTaskRunner(), FROM_HERE,
137 base::Bind(&GetDeviceDescriptionsOnDeviceThread,
138 base::Unretained(audio_manager_), for_input),
139 std::move(on_descriptions_cp));
140 }
141
112 AudioManager* AudioSystemImpl::GetAudioManager() const { 142 AudioManager* AudioSystemImpl::GetAudioManager() const {
113 return audio_manager_; 143 return audio_manager_;
114 } 144 }
115 145
116 base::SingleThreadTaskRunner* AudioSystemImpl::GetTaskRunner() const { 146 base::SingleThreadTaskRunner* AudioSystemImpl::GetTaskRunner() const {
117 return audio_manager_->GetTaskRunner(); 147 return audio_manager_->GetTaskRunner();
118 } 148 }
119 149
120 } // namespace media 150 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698