Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 2761113002: Move getNavigationType logic from PerformanceBase to PerformanceNavigationTiming. (Closed)

Created:
3 years, 9 months ago by sunjian
Modified:
3 years, 8 months ago
Reviewers:
haraken, panicker
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move getNavigationType logic from PerformanceBase to PerformanceNavigationTiming. Currently, the type() method in PerformanceNavigationTiming will call PerformanceBase::getNavigationType(). Since PNT is the only caller of this method. It makes more sense to merge this logic into PNT. BUG=703409 Review-Url: https://codereview.chromium.org/2761113002 Cr-Commit-Position: refs/heads/master@{#460873} Committed: https://chromium.googlesource.com/chromium/src/+/5d663f46bd1cef7b00e9a52b5148af16014ec652

Patch Set 1 #

Patch Set 2 : add null checking for m_frame since is a WeakMember #

Patch Set 3 : sync to HEAD #

Patch Set 4 : sync to HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -64 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceBase.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceBase.cpp View 1 chunk +0 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.cpp View 1 2 2 chunks +24 lines, -15 lines 0 comments Download
A third_party/WebKit/Source/core/timing/PerformanceNavigationTimingTest.cpp View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761113002/1
3 years, 9 months ago (2017-03-20 23:49:57 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 9 months ago (2017-03-20 23:49:59 UTC) #5
sunjian
3 years, 8 months ago (2017-03-28 21:55:46 UTC) #7
panicker
LGTM. Kentaro - can you review for owners (this was broken out of https://codereview.chromium.org/2647643004/ (where ...
3 years, 8 months ago (2017-03-29 17:37:31 UTC) #9
haraken
LGTM
3 years, 8 months ago (2017-03-29 23:55:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761113002/40001
3 years, 8 months ago (2017-03-30 00:04:19 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 8 months ago (2017-03-30 02:07:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761113002/60001
3 years, 8 months ago (2017-03-30 18:38:21 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 21:06:21 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5d663f46bd1cef7b00e9a52b5148...

Powered by Google App Engine
This is Rietveld 408576698