Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp

Issue 2761113002: Move getNavigationType logic from PerformanceBase to PerformanceNavigationTiming. (Closed)
Patch Set: sync to HEAD Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
diff --git a/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp b/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
index 932c3df4fc9dcb0b0885bbf822afea704dce77ef..911d279f45e07684706196bd6f901fd6fdc06314 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
+++ b/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
@@ -139,27 +139,6 @@ TEST_F(PerformanceBaseTest, AddLongTaskTiming) {
EXPECT_EQ(1, numPerformanceEntriesInObserver()); // added an entry
}
-TEST_F(PerformanceBaseTest, GetNavigationType) {
- m_pageHolder->page().setVisibilityState(PageVisibilityStatePrerender, false);
- PerformanceNavigationTiming::NavigationType returnedType =
- PerformanceBase::getNavigationType(NavigationTypeBackForward,
- &m_pageHolder->document());
- EXPECT_EQ(returnedType,
- PerformanceNavigationTiming::NavigationType::Prerender);
-
- m_pageHolder->page().setVisibilityState(PageVisibilityStateHidden, false);
- returnedType = PerformanceBase::getNavigationType(NavigationTypeBackForward,
- &m_pageHolder->document());
- EXPECT_EQ(returnedType,
- PerformanceNavigationTiming::NavigationType::BackForward);
-
- m_pageHolder->page().setVisibilityState(PageVisibilityStateVisible, false);
- returnedType = PerformanceBase::getNavigationType(
- NavigationTypeFormResubmitted, &m_pageHolder->document());
- EXPECT_EQ(returnedType,
- PerformanceNavigationTiming::NavigationType::Navigate);
-}
-
TEST_F(PerformanceBaseTest, AllowsTimingRedirect) {
// When there are no cross-origin redirects.
AtomicString originDomain = "http://127.0.0.1:8000";

Powered by Google App Engine
This is Rietveld 408576698