Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2760983003: PPC: Clean up simulator code by introducing a OpcodeBase function (Closed)

Created:
3 years, 9 months ago by Sampson
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Clean up simulator code by introducing a OpcodeBase function R=bjaideep@ca.ibm.com, jyan@ca.ibm.com, joransiu@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2760983003 Cr-Commit-Position: refs/heads/master@{#44070} Committed: https://chromium.googlesource.com/v8/v8/+/a8119306f5e3beedee0a321c6855653b394d12f5

Patch Set 1 #

Patch Set 2 : Correct XX2 format bit field #

Patch Set 3 : Correct some other formats bit field #

Patch Set 4 : Add missing cases in simulator #

Unified diffs Side-by-side diffs Delta from patch set Stats (+678 lines, -756 lines) Patch
M src/ppc/constants-ppc.h View 1 2 3 6 chunks +113 lines, -52 lines 0 comments Download
M src/ppc/simulator-ppc.cc View 1 2 3 12 chunks +565 lines, -704 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Sampson
Please take a look.
3 years, 9 months ago (2017-03-21 19:33:23 UTC) #1
JaideepBajwa
lgtm
3 years, 9 months ago (2017-03-23 01:30:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760983003/60001
3 years, 9 months ago (2017-03-23 15:15:30 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 9 months ago (2017-03-23 15:15:32 UTC) #6
john.yan
lgtm
3 years, 9 months ago (2017-03-23 15:31:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760983003/60001
3 years, 9 months ago (2017-03-23 15:31:59 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 15:58:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/a8119306f5e3beedee0a321c6855653b394...

Powered by Google App Engine
This is Rietveld 408576698