src/full-codegen/ia32/full-codegen-ia32.cc - Issue 2760953002: [builtins] Move more files into v8_builtins_generators source set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 2760953002: [builtins] Move more files into v8_builtins_generators source set (Closed)

Patch Set: rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/ia32/full-codegen-ia32.cc

diff --git a/src/full-codegen/ia32/full-codegen-ia32.cc b/src/full-codegen/ia32/full-codegen-ia32.cc

index 86e0ccc8dc885c7aaf98d79fb4bd8b7fe5a014f7..ae955fb73ffad8acd53863b41507e9bb59aca9c5 100644

--- a/src/full-codegen/ia32/full-codegen-ia32.cc

+++ b/src/full-codegen/ia32/full-codegen-ia32.cc

@@ -188,8 +188,7 @@ void FullCodeGenerator::Generate() {

if (info->scope()->new_target_var() != nullptr) {

__ push(edx); // Preserve new target.

}

- if (slots <=

- ConstructorBuiltinsAssembler::MaximumFunctionContextSlots()) {

+ if (slots <= ConstructorBuiltins::MaximumFunctionContextSlots()) {

Callable callable = CodeFactory::FastNewFunctionContext(

isolate(), info->scope()->scope_type());

__ mov(FastNewFunctionContextDescriptor::SlotsRegister(),