build/android/pylib/local/device/local_device_instrumentation_test_run.py - Issue 2760923002: [build/android] Fix device.RunShellCommand usages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/local/device/local_device_instrumentation_test_run.py

Issue 2760923002: [build/android] Fix device.RunShellCommand usages (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/android/pylib/local/device/local_device_gtest_run.py ('K') | « build/android/pylib/local/device/local_device_gtest_run.py ('k') | build/android/pylib/local/device/local_device_monkey_test_run.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/pylib/local/device/local_device_instrumentation_test_run.py

diff --git a/build/android/pylib/local/device/local_device_instrumentation_test_run.py b/build/android/pylib/local/device/local_device_instrumentation_test_run.py

index 3adced357ef8cb6a9acfed93c4a038ce48a8051f..d3e636e20dff957d141e161ffa6a5d00c3939459 100644

--- a/build/android/pylib/local/device/local_device_instrumentation_test_run.py

+++ b/build/android/pylib/local/device/local_device_instrumentation_test_run.py

@@ -380,8 +380,9 @@ class LocalDeviceInstrumentationTestRun(

if self._test_instance.coverage_directory:

device.PullFile(coverage_directory,

self._test_instance.coverage_directory)

- device.RunShellCommand('rm -f %s' % os.path.join(coverage_directory,

- '*'))

+ device.RunShellCommand(

+ 'rm -f %s' % posixpath.join(coverage_directory, '*'),

+ check_return=True, shell=True)

perezju 2017/03/20 15:22:58 This appears to be sort of common-ish, wondering w

jbudorick 2017/03/20 15:27:02 Maybe an addition to https://codesearch.chromium.o

if self._test_instance.store_tombstones:

tombstones_url = None

for result in results:

@@ -435,4 +436,3 @@ class LocalDeviceInstrumentationTestRun(

timeout *= cls._GetTimeoutScaleFromAnnotations(annotations)

return timeout