[build/android] Fix device.RunShellCommand usages

build/android/pylib/local/device/local_device_instrumentation_test_run.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import os
 import posixpath
 import re
 import time
 
@@ skipping 362 matching lines @@
         device.ClearApplicationState(self._test_instance.package_info.package,
                                      permissions=permissions)
 
     else:
       logging.debug('raw output from %s:', test_display_name)
       for l in output:
         logging.debug('  %s', l)
     if self._test_instance.coverage_directory:
       device.PullFile(coverage_directory,
           self._test_instance.coverage_directory)
-      device.RunShellCommand('rm -f %s' % os.path.join(coverage_directory,
-          '*'))
+      device.RunShellCommand(
+          'rm -f %s' % posixpath.join(coverage_directory, '*'),
+          check_return=True, shell=True)

[perezju, 2017/03/20 15:22:58]

This appears to be sort of common-ish, wondering whether we want some
"RemovePathContents".

[jbudorick, 2017/03/20 15:27:02]

Maybe an addition to
https://codesearch.chromium.org/chromium/src/third_party/catapult/devil/devil...
?

     if self._test_instance.store_tombstones:
       tombstones_url = None
       for result in results:
         if result.GetType() == base_test_result.ResultType.CRASH:
           if not tombstones_url:
             resolved_tombstones = tombstones.ResolveTombstones(
                 device,
                 resolve_all_tombstones=True,
                 include_stack_symbols=False,
                 wipe_tombstones=True)
@@ skipping 33 matching lines @@
       if k in annotations:
         timeout = v
         break
     else:
       logging.warning('Using default 1 minute timeout for %s', test_name)
       timeout = 60
 
     timeout *= cls._GetTimeoutScaleFromAnnotations(annotations)
 
     return timeout
-