build/android/pylib/local/device/local_device_gtest_run.py - Issue 2760923002: [build/android] Fix device.RunShellCommand usages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/local/device/local_device_gtest_run.py

Issue 2760923002: [build/android] Fix device.RunShellCommand usages (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/local/device/local_device_gtest_run.py

diff --git a/build/android/pylib/local/device/local_device_gtest_run.py b/build/android/pylib/local/device/local_device_gtest_run.py

index 552379dd6cb768091eb12be22186f5bfa73df7aa..4856f596d2bbc2b582ab4f0acb562c861aafd0a1 100644

--- a/build/android/pylib/local/device/local_device_gtest_run.py

+++ b/build/android/pylib/local/device/local_device_gtest_run.py

@@ -234,6 +234,8 @@ class _ExeDelegate(object):

except (device_errors.CommandFailedError, KeyError):

pass

+ # Executable tests return a nonzero exit code on test failure, which is

+ # fine from the test runner's perspective; thus check_return=False.

perezju 2017/03/20 15:22:58 Had to search through commit messages to figure ou

jbudorick 2017/03/20 15:27:02 woops, this is probably something I should've docu

output = device.RunShellCommand(

cmd, cwd=cwd, env=env, check_return=False, large_output=True, **kwargs)

return output