DescriptionRevert of [Extensions] Un-filter-ify and Un-managed-ify webview events (patchset #1 id:1 of https://codereview.chromium.org/2750313004/ )
Reason for revert:
WebView tests broken: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/44259
Original issue's description:
> [Extensions] Un-filter-ify and Un-managed-ify webview events
>
> Extension events support "filters", which can be used to filter out
> uninteresting events. Currently, these are predominantly used in
> the webNavigation and webRequest events. For some reason, webview
> events support filters. They shouldn't, since the only events that
> require it (the webview version of webRequest) use a different event
> constructor.
>
> Additionally, webview events are currently considered "managed", which
> means they will notify the browser of added/removed listeners. Since all
> the dispatching appears to be done through JS "manually", we should be
> able to remove this as well.
>
> Removing these results in much simpler event logic being executed,
> avoidance of sending IPCs to the browser, and fewer jumps between
> JS and C++.
>
> BUG=None
>
> Review-Url: https://codereview.chromium.org/2750313004
> Cr-Commit-Position: refs/heads/master@{#457840}
> Committed: https://chromium.googlesource.com/chromium/src/+/b448f058eaaad3baa7ad402d45885fb867e65c94
TBR=lazyboy@chromium.org,paulmeyer@chromium.org,rdevlin.cronin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
Review-Url: https://codereview.chromium.org/2760703002
Cr-Commit-Position: refs/heads/master@{#457876}
Committed: https://chromium.googlesource.com/chromium/src/+/0747b351e7d8684c8282535617366dad0a27d602
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|