Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2760703002: Revert of [Extensions] Un-filter-ify and Un-managed-ify webview events (Closed)

Created:
3 years, 9 months ago by Dmitry Titov
Modified:
3 years, 9 months ago
Reviewers:
paulmeyer, lazyboy, Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Extensions] Un-filter-ify and Un-managed-ify webview events (patchset #1 id:1 of https://codereview.chromium.org/2750313004/ ) Reason for revert: WebView tests broken: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/44259 Original issue's description: > [Extensions] Un-filter-ify and Un-managed-ify webview events > > Extension events support "filters", which can be used to filter out > uninteresting events. Currently, these are predominantly used in > the webNavigation and webRequest events. For some reason, webview > events support filters. They shouldn't, since the only events that > require it (the webview version of webRequest) use a different event > constructor. > > Additionally, webview events are currently considered "managed", which > means they will notify the browser of added/removed listeners. Since all > the dispatching appears to be done through JS "manually", we should be > able to remove this as well. > > Removing these results in much simpler event logic being executed, > avoidance of sending IPCs to the browser, and fewer jumps between > JS and C++. > > BUG=None > > Review-Url: https://codereview.chromium.org/2750313004 > Cr-Commit-Position: refs/heads/master@{#457840} > Committed: https://chromium.googlesource.com/chromium/src/+/b448f058eaaad3baa7ad402d45885fb867e65c94 TBR=lazyboy@chromium.org,paulmeyer@chromium.org,rdevlin.cronin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.chromium.org/2760703002 Cr-Commit-Position: refs/heads/master@{#457876} Committed: https://chromium.googlesource.com/chromium/src/+/0747b351e7d8684c8282535617366dad0a27d602

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M extensions/renderer/resources/guest_view/guest_view_events.js View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Dmitry Titov
Created Revert of [Extensions] Un-filter-ify and Un-managed-ify webview events
3 years, 9 months ago (2017-03-17 20:39:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760703002/1
3 years, 9 months ago (2017-03-17 20:39:56 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 20:41:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0747b351e7d8684c828253561736...

Powered by Google App Engine
This is Rietveld 408576698