[Extensions] Un-filter-ify and Un-managed-ify webview events

[Extensions] Un-filter-ify and Un-managed-ify webview events

Extension events support "filters", which can be used to filter out
uninteresting events. Currently, these are predominantly used in
the webNavigation and webRequest events. For some reason, webview
events support filters. They shouldn't, since the only events that
require it (the webview version of webRequest) use a different event
constructor.

Additionally, webview events are currently considered "managed", which
means they will notify the browser of added/removed listeners. Since all
the dispatching appears to be done through JS "manually", we should be
able to remove this as well.

Removing these results in much simpler event logic being executed,
avoidance of sending IPCs to the browser, and fewer jumps between
JS and C++.

BUG=None

Review-Url: https://codereview.chromium.org/2750313004
Cr-Commit-Position: refs/heads/master@{#457840}
Committed: https://chromium.googlesource.com/chromium/src/+/b448f058eaaad3baa7ad402d45885fb867e65c94

[Devlin, 2017-03-16 21:44:58]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 21:45:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 21:55:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 21:55:32]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-03-16 22:36:45]

Description was changed from

==========
test

BUG=
==========

to

==========
[Extensions] Un-filter-ify and Un-managed-ify webview events

Extension events support "filters", which can be used to filter out
uninteresting events. Currently, these are predominantly used in
the webNavigation and webRequest events. For some reason, webview
events support filters. They shouldn't, since the only events that
require it (the webview version of webRequest) use a different event
constructor.

Additionally, webview events are currently considered "managed", which
means they will notify the browser of added/removed listeners. Since all
the dispatching appears to be done through JS "manually", we should be
able to remove this as well.

Removing these results in much simpler event logic being executed,
avoidance of sending IPCs to the browser, and fewer jumps between
JS and C++.

BUG=None
==========

[Devlin, 2017-03-16 22:38:23]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Devlin, 2017-03-16 22:38:24]

lazyboy@, can you take a look?  I traced this back (I think) to
crrev.com/1869937705df919aff92cb54888527ccbaf62702, which seems to have added
it, but doesn't offer explanation as to the values used.  As far as I can tell,
the filtered events we use are a separate class that don't go through this flow,
and it appears that all these events are dispatched through JS, rather than
through the browser.  You probably know this code better, though, and it's
possible I'm missing something.

[lazyboy, 2017-03-17 18:21:15]

lazyboy@chromium.org changed reviewers:
+ paulmeyer@chromium.org

[lazyboy, 2017-03-17 18:21:16]

lgtm, I think this is fine, but wanted another set of eyes to take a look,
adding Paul as reviewer for that.

[paulmeyer, 2017-03-17 18:25:15]

On 2017/03/17 18:21:16, lazyboy wrote:
> lgtm, I think this is fine, but wanted another set of eyes to take a look,
> adding Paul as reviewer for that.

LGTM

[Devlin, 2017-03-17 19:00:41]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2017-03-17 19:01:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 19:09:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489777241094580, "parent_rev":
"457f1988af83ecf544aa76a8ee8126f6ac980c41", "commit_rev":
"b448f058eaaad3baa7ad402d45885fb867e65c94"}

[commit-bot: I haz the power, 2017-03-17 19:10:21]

Description was changed from

==========
[Extensions] Un-filter-ify and Un-managed-ify webview events

Extension events support "filters", which can be used to filter out
uninteresting events. Currently, these are predominantly used in
the webNavigation and webRequest events. For some reason, webview
events support filters. They shouldn't, since the only events that
require it (the webview version of webRequest) use a different event
constructor.

Additionally, webview events are currently considered "managed", which
means they will notify the browser of added/removed listeners. Since all
the dispatching appears to be done through JS "manually", we should be
able to remove this as well.

Removing these results in much simpler event logic being executed,
avoidance of sending IPCs to the browser, and fewer jumps between
JS and C++.

BUG=None
==========

to

==========
[Extensions] Un-filter-ify and Un-managed-ify webview events

Extension events support "filters", which can be used to filter out
uninteresting events. Currently, these are predominantly used in
the webNavigation and webRequest events. For some reason, webview
events support filters. They shouldn't, since the only events that
require it (the webview version of webRequest) use a different event
constructor.

Additionally, webview events are currently considered "managed", which
means they will notify the browser of added/removed listeners. Since all
the dispatching appears to be done through JS "manually", we should be
able to remove this as well.

Removing these results in much simpler event logic being executed,
avoidance of sending IPCs to the browser, and fewer jumps between
JS and C++.

BUG=None

Review-Url: https://codereview.chromium.org/2750313004
Cr-Commit-Position: refs/heads/master@{#457840}
Committed:
https://chromium.googlesource.com/chromium/src/+/b448f058eaaad3baa7ad402d4588...
==========

[commit-bot: I haz the power, 2017-03-17 19:10:23]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b448f058eaaad3baa7ad402d4588...

[Dmitry Titov, 2017-03-17 20:39:31]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2760703002/ by dimich@chromium.org.

The reason for reverting is: WebView tests broken:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%....