Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2760573002: Change the target type of platform_wtf to source_set. (Closed)

Created:
3 years, 9 months ago by Yuta Kitamura
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the target type of platform_wtf to source_set. A CL (https://codereview.chromium.org/2741343017) failed to compile on Windows Debug try bots because files in wtf/ lacked __declspec(dllimport) even though they need to import symbols defined in platform_wtf. Conceptually, platform_wtf and wtf are a single link unit, thus the target type of "component" was inappropriate; it should have been "source_set" instead. This change is supposed to fix the compile error mentioned above. BUG=691465 Review-Url: https://codereview.chromium.org/2760573002 Cr-Commit-Position: refs/heads/master@{#457743} Committed: https://chromium.googlesource.com/chromium/src/+/66f935ee4b824e930ef6fb8aafd96563bdaf0e88

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/wtf/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Yuta Kitamura
Context: part 4 could not be landed because of Windows build failure. I think this ...
3 years, 9 months ago (2017-03-17 09:25:48 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-03-17 09:36:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760573002/1
3 years, 9 months ago (2017-03-17 12:46:13 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 12:51:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/66f935ee4b824e930ef6fb8aafd9...

Powered by Google App Engine
This is Rietveld 408576698