Move files in wtf/ to platform/wtf/ (Part 4).

Move files in wtf/ to platform/wtf/ (Part 4).

This patch moves the following files to platform/wtf/.

    ASCIICType.{h,cpp}
    Assertions.h (Note: Assertions.cpp is left in wtf/; see below.)
    Atomics.h
    SpinLock.h
    StringExtras.h
    text/Unicode.h
    text/icu/UnicodeIcu.h

Assertions.cpp is still in wtf/, but this is safe because no cpp files in
wtf/ and platform/wtf/ use the symbols defined in Assertions.cpp.
Assertions.cpp has dependencies to Threading.h and ThreadSpecific.h, which
cannot be moved easily, so it will be moved in a later batch.

BUG=691465
Review-Url: https://codereview.chromium.org/2741343017
Cr-Commit-Position: refs/heads/master@{#458305}
Committed: https://chromium.googlesource.com/chromium/src/+/ecdb463e1dee6caa00d6c4c805af7f1608f558f5

[Yuta Kitamura, 2017-03-16 09:47:21]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 09:47:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuta Kitamura, 2017-03-16 09:51:04]

yutak@chromium.org changed reviewers:
+ haraken@chromium.org

[Yuta Kitamura, 2017-03-16 09:51:05]

PTAL

[haraken, 2017-03-16 09:53:21]

LGTM

[commit-bot: I haz the power, 2017-03-16 10:57:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 10:57:16]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Yuta Kitamura, 2017-03-17 04:27:49]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 04:28:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 05:48:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 05:48:12]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Yuta Kitamura, 2017-03-17 12:56:10]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 12:56:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 14:06:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 14:06:09]

Dry run: This issue passed the CQ dry run.

[Yuta Kitamura, 2017-03-17 18:19:42]

FYI, I applied a small change that moves the inlined
implementation of a static member function.

I think this is trivial and harmless, so I'm landing
this now. Let me know if that's an issue.

[Yuta Kitamura, 2017-03-17 18:19:50]

The CQ bit was checked by yutak@chromium.org

[Yuta Kitamura, 2017-03-17 18:19:51]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2741343017/#ps20001
(title: "De-inline a static member function to fix Windows build.")

[commit-bot: I haz the power, 2017-03-17 18:20:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 18:27:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 18:27:47]

Failed to apply patch for third_party/WebKit/Source/platform/wtf/BUILD.gn:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/Source/platform/wtf/BUILD.gn:59
  error: third_party/WebKit/Source/platform/wtf/BUILD.gn: patch does not apply

Patch:       third_party/WebKit/Source/platform/wtf/BUILD.gn
Index: third_party/WebKit/Source/platform/wtf/BUILD.gn
diff --git a/third_party/WebKit/Source/platform/wtf/BUILD.gn
b/third_party/WebKit/Source/platform/wtf/BUILD.gn
index
9c198053141e83cc28e6e3c129af5883c20e6f78..f321ab7a5b1f33321f916e97d3a037f3c4e257aa
100644
--- a/third_party/WebKit/Source/platform/wtf/BUILD.gn
+++ b/third_party/WebKit/Source/platform/wtf/BUILD.gn
@@ -59,8 +59,12 @@ config("wtf_config") {
 
 component("platform_wtf") {
   sources = [
+    "ASCIICType.cpp",
+    "ASCIICType.h",
     "AddressSanitizer.h",
     "Alignment.h",
+    "Assertions.h",
+    "Atomics.h",
     "AutoReset.h",
     "BitwiseOperations.h",
     "ByteSwap.h",
@@ -83,12 +87,16 @@ component("platform_wtf") {
     "NotFound.h",
     "Optional.h",
     "SizeAssertions.h",
+    "SpinLock.h",
     "StaticConstructors.h",
+    "StringExtras.h",
     "Time.h",
     "TriState.h",
     "TypeTraits.h",
     "WTFExport.h",
     "build_config.h",
+    "text/Unicode.h",
+    "text/icu/UnicodeIcu.h",
   ]
 
   configs += [

[Yuta Kitamura, 2017-03-21 01:15:44]

The CQ bit was checked by yutak@chromium.org

[Yuta Kitamura, 2017-03-21 01:15:45]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2741343017/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-03-21 01:16:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 02:23:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 02:23:48]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Yuta Kitamura, 2017-03-21 02:39:49]

The CQ bit was checked by yutak@chromium.org

[commit-bot: I haz the power, 2017-03-21 02:40:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 03:57:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490063989245470,
"parent_rev": "436ba300cd088e37bb6db325717baf096d23876c", "commit_rev":
"ecdb463e1dee6caa00d6c4c805af7f1608f558f5"}

[commit-bot: I haz the power, 2017-03-21 03:58:17]

Description was changed from

==========
Move files in wtf/ to platform/wtf/ (Part 4).

This patch moves the following files to platform/wtf/.

    ASCIICType.{h,cpp}
    Assertions.h (Note: Assertions.cpp is left in wtf/; see below.)
    Atomics.h
    SpinLock.h
    StringExtras.h
    text/Unicode.h
    text/icu/UnicodeIcu.h

Assertions.cpp is still in wtf/, but this is safe because no cpp files in
wtf/ and platform/wtf/ use the symbols defined in Assertions.cpp.
Assertions.cpp has dependencies to Threading.h and ThreadSpecific.h, which
cannot be moved easily, so it will be moved in a later batch.

BUG=691465
==========

to

==========
Move files in wtf/ to platform/wtf/ (Part 4).

This patch moves the following files to platform/wtf/.

    ASCIICType.{h,cpp}
    Assertions.h (Note: Assertions.cpp is left in wtf/; see below.)
    Atomics.h
    SpinLock.h
    StringExtras.h
    text/Unicode.h
    text/icu/UnicodeIcu.h

Assertions.cpp is still in wtf/, but this is safe because no cpp files in
wtf/ and platform/wtf/ use the symbols defined in Assertions.cpp.
Assertions.cpp has dependencies to Threading.h and ThreadSpecific.h, which
cannot be moved easily, so it will be moved in a later batch.

BUG=691465

Review-Url: https://codereview.chromium.org/2741343017
Cr-Commit-Position: refs/heads/master@{#458305}
Committed:
https://chromium.googlesource.com/chromium/src/+/ecdb463e1dee6caa00d6c4c805af...
==========

[commit-bot: I haz the power, 2017-03-21 03:58:18]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ecdb463e1dee6caa00d6c4c805af...