Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2760463004: Simplification: Remove support for specifying suffix lists when rebaselining. (Closed)

Created:
3 years, 9 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, chromium-reviews, jeffcarp, wkorman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplification: Remove support for specifying suffix lists when rebaselining. Reason: This would simplify the test_prefix_list variables and related code. It would also remove support for passing suffixes to `webkit-patch rebaseline`, but in practice, I think that's not a very useful feature anyway because when one wants to rebaseline a test, one generally wants to download all relevant baselines (both text and image, for example). BUG=702819 Review-Url: https://codereview.chromium.org/2760463004 Cr-Commit-Position: refs/heads/master@{#457926} Committed: https://chromium.googlesource.com/chromium/src/+/4494b892750fe71d43c2dc0cef3247a38d777b42

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove blank lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -69 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py View 1 12 chunks +40 lines, -47 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py View 6 chunks +20 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
qyearsley
3 years, 9 months ago (2017-03-17 22:42:42 UTC) #4
Xianzhu
lgtm https://codereview.chromium.org/2760463004/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py File third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py (right): https://codereview.chromium.org/2760463004/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py#newcode368 third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py:368: Nit: The blank line just looks weird. Feel ...
3 years, 9 months ago (2017-03-18 00:07:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760463004/20001
3 years, 9 months ago (2017-03-18 00:26:27 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-18 02:16:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4494b892750fe71d43c2dc0cef32...

Powered by Google App Engine
This is Rietveld 408576698