Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1138)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py

Issue 2760463004: Simplification: Remove support for specifying suffix lists when rebaselining. (Closed)
Patch Set: Remove blank lines Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
index 2c4eed4ea8b9739ab0411a16e330768217ff6546..5fe34cae5fabe1ec6f977dbdb26082de19a49151 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
@@ -9,7 +9,6 @@ import logging
import optparse
from webkitpy.common.net.git_cl import GitCL
-from webkitpy.layout_tests.models.test_expectations import BASELINE_SUFFIX_LIST
from webkitpy.tool.commands.rebaseline import AbstractParallelRebaselineCommand
from webkitpy.w3c.wpt_manifest import WPTManifest
@@ -90,7 +89,7 @@ class RebaselineCL(AbstractParallelRebaselineCommand):
test_prefix_list = {}
if args:
for test in args:
- test_prefix_list[test] = {b: BASELINE_SUFFIX_LIST for b in builds}
+ test_prefix_list[test] = builds
else:
test_prefix_list = self._test_prefix_list(
builds_to_results,
@@ -192,8 +191,8 @@ class RebaselineCL(AbstractParallelRebaselineCommand):
if only_changed_tests and test not in tests_in_cl:
continue
if test not in result:
- result[test] = {}
- result[test][build] = BASELINE_SUFFIX_LIST
+ result[test] = []
+ result[test].append(build)
return result
def _tests_to_rebaseline(self, build, layout_test_results):

Powered by Google App Engine
This is Rietveld 408576698