Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 2760423002: Allow sign in while browser is opened when force-sign-in policy is enabled. (Closed)

Created:
3 years, 9 months ago by zmin
Modified:
3 years, 9 months ago
Reviewers:
anthonyvd
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow sign in while browser is opened when force-sign-in policy is enabled. Because force-sign-in policy won't force browser window closing before sign out when user is using Chrome, force-sign-in policy will support sign in with browser opened. Also add some browser test. BUG=642059 BUG=681230 BUG=682661 BUG=686743 Review-Url: https://codereview.chromium.org/2760423002 Cr-Commit-Position: refs/heads/master@{#459501} Committed: https://chromium.googlesource.com/chromium/src/+/49f6220a80ff68d06c6c1c5179d0e494e0b8ad00

Patch Set 1 #

Patch Set 2 : fixup #

Total comments: 2

Patch Set 3 : CR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -62 lines) Patch
M chrome/browser/ui/webui/signin/inline_login_handler_impl.h View 1 2 4 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_handler_impl.cc View 11 chunks +25 lines, -19 lines 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc View 1 12 chunks +85 lines, -41 lines 0 comments Download

Messages

Total messages: 23 (18 generated)
zmin
Hi anthonyvd@ Can you review this please? Owen
3 years, 9 months ago (2017-03-21 21:18:31 UTC) #13
anthonyvd
lgtm https://codereview.chromium.org/2760423002/diff/40001/chrome/browser/ui/webui/signin/inline_login_handler_impl.h File chrome/browser/ui/webui/signin/inline_login_handler_impl.h (right): https://codereview.chromium.org/2760423002/diff/40001/chrome/browser/ui/webui/signin/inline_login_handler_impl.h#newcode116 chrome/browser/ui/webui/signin/inline_login_handler_impl.h:116: // True if user sign in with UserManager ...
3 years, 9 months ago (2017-03-24 16:25:33 UTC) #16
zmin
https://codereview.chromium.org/2760423002/diff/40001/chrome/browser/ui/webui/signin/inline_login_handler_impl.h File chrome/browser/ui/webui/signin/inline_login_handler_impl.h (right): https://codereview.chromium.org/2760423002/diff/40001/chrome/browser/ui/webui/signin/inline_login_handler_impl.h#newcode116 chrome/browser/ui/webui/signin/inline_login_handler_impl.h:116: // True if user sign in with UserManager when ...
3 years, 9 months ago (2017-03-24 18:02:02 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760423002/60001
3 years, 9 months ago (2017-03-24 18:04:44 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 18:59:50 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/49f6220a80ff68d06c6c1c5179d0...

Powered by Google App Engine
This is Rietveld 408576698