Allow sign in while browser is opened when force-sign-in policy is enabled.

chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/content_settings/cookie_settings_factory.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/profiles/profile_attributes_entry.h"
+#include "chrome/browser/profiles/profile_attributes_storage.h"
+#include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/signin/fake_profile_oauth2_token_service_builder.h"
 #include "chrome/browser/signin/fake_signin_manager_builder.h"
 #include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/signin/signin_promo.h"
 #include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/webui/signin/inline_login_handler_impl.h"
 #include "chrome/browser/ui/webui/signin/inline_login_ui.h"
 #include "chrome/browser/ui/webui/signin/login_ui_service.h"
 #include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
 #include "chrome/browser/ui/webui/signin/login_ui_test_utils.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/chromium_strings.h"
 #include "chrome/grit/generated_resources.h"
@@ skipping 154 matching lines @@
                          profile,
                          Profile::CreateStatus::CREATE_STATUS_INITIALIZED,
                          current_url,
                          email,
                          gaia_id,
                          password,
                          session_index,
                          auth_code,
                          signin_scoped_device_id,
                          choose_what_to_sync,
-                         confirm_untrusted_signin) {}
+                         confirm_untrusted_signin,
+                         false) {}
 
 // This class is used to mock out virtual methods with side effects so that
 // tests below can ensure they are called without causing side effects.
 class MockSyncStarterInlineSigninHelper : public InlineSigninHelper {
  public:
   MockSyncStarterInlineSigninHelper(
       base::WeakPtr<InlineLoginHandlerImpl> handler,
       net::URLRequestContextGetter* getter,
       Profile* profile,
       const GURL& current_url,
       const std::string& email,
       const std::string& gaia_id,
       const std::string& password,
       const std::string& session_index,
       const std::string& auth_code,
       const std::string& signin_scoped_device_id,
       bool choose_what_to_sync,
-      bool confirm_untrusted_signin);
+      bool confirm_untrusted_signin,
+      bool is_force_sign_in_with_usermanager);
 
   MOCK_METHOD8(CreateSyncStarter,
                void(Browser*,
                     content::WebContents*,
                     const GURL&,
                     const GURL&,
                     const std::string&,
                     OneClickSigninSyncStarter::ProfileMode,
                     OneClickSigninSyncStarter::StartSyncMode,
                     OneClickSigninSyncStarter::ConfirmationRequired));
 
  private:
   DISALLOW_COPY_AND_ASSIGN(MockSyncStarterInlineSigninHelper);
 };
 
 MockSyncStarterInlineSigninHelper::MockSyncStarterInlineSigninHelper(
     base::WeakPtr<InlineLoginHandlerImpl> handler,
     net::URLRequestContextGetter* getter,
     Profile* profile,
     const GURL& current_url,
     const std::string& email,
     const std::string& gaia_id,
     const std::string& password,
     const std::string& session_index,
     const std::string& auth_code,
     const std::string& signin_scoped_device_id,
     bool choose_what_to_sync,
-    bool confirm_untrusted_signin)
+    bool confirm_untrusted_signin,
+    bool is_force_sign_in_with_usermanager)
     : InlineSigninHelper(handler,
                          getter,
                          profile,
                          Profile::CreateStatus::CREATE_STATUS_INITIALIZED,
                          current_url,
                          email,
                          gaia_id,
                          password,
                          session_index,
                          auth_code,
                          signin_scoped_device_id,
                          choose_what_to_sync,
-                         confirm_untrusted_signin) {}
+                         confirm_untrusted_signin,
+                         is_force_sign_in_with_usermanager) {}
 
 }  // namespace
 
 class InlineLoginUIBrowserTest : public InProcessBrowserTest {
  public:
   InlineLoginUIBrowserTest() {}
 
   void SetUpSigninManager(const std::string& username);
   void EnableSigninAllowed(bool enable);
   void EnableOneClick(bool enable);
@@ skipping 310 matching lines @@
                        SigninCreatesSyncStarter1) {
   // See Source enum in components/signin/core/browser/signin_metrics.h for
   // possible values of access_point=, reason=.
   GURL url("chrome://chrome-signin/?access_point=0&reason=0");
   base::WeakPtr<InlineLoginHandlerImpl> handler;
   // MockSyncStarterInlineSigninHelper will delete itself when done using
   // base::ThreadTaskRunnerHandle::DeleteSoon(), so need to delete here.  But
   // do need the RunUntilIdle() at the end.
   MockSyncStarterInlineSigninHelper* helper =
       new MockSyncStarterInlineSigninHelper(
-          handler,
-          browser()->profile()->GetRequestContext(),
-          browser()->profile(),
-          url,
-          "foo@gmail.com",
-          "gaiaid-12345",
+          handler, browser()->profile()->GetRequestContext(),
+          browser()->profile(), url, "foo@gmail.com", "gaiaid-12345",
           "password",
-          "",  // session index
+          "",           // session index
           "auth_code",  // auth code
           std::string(),
           false,  // choose what to sync
-          false);  // confirm untrusted signin
+          false,  // confirm untrusted signin
+          false);
   EXPECT_CALL(
       *helper,
       CreateSyncStarter(_, _, _, _, "refresh_token",
                         OneClickSigninSyncStarter::CURRENT_PROFILE,
                         OneClickSigninSyncStarter::CONFIRM_SYNC_SETTINGS_FIRST,
                         OneClickSigninSyncStarter::CONFIRM_AFTER_SIGNIN));
 
+  ProfileAttributesEntry* entry;
+  ASSERT_TRUE(g_browser_process->profile_manager()
+                  ->GetProfileAttributesStorage()
+                  .GetProfileAttributesWithPath(browser()->profile()->GetPath(),
+                                                &entry));
+  entry->SetIsSigninRequired(true);
+
+  ASSERT_EQ(1ul, BrowserList::GetInstance()->size());
   SimulateOnClientOAuthSuccess(helper, "refresh_token");
   base::RunLoop().RunUntilIdle();
+  ASSERT_EQ(1ul, BrowserList::GetInstance()->size());
+  // if |force_sign_in_with_user_manager| is false, the profile should be
+  // unlocked early and InlineLoginHelper won't try to do it again
+  ASSERT_TRUE(entry->IsSigninRequired());
 }
 
 // Test signin helper creates sync starter with correct confirmation when
 // signing in and choosing what to sync first.
 IN_PROC_BROWSER_TEST_F(InlineLoginHelperBrowserTest,
                        SigninCreatesSyncStarter2) {
   // See Source enum in components/signin/core/browser/signin_metrics.h for
   // possible values of access_point=, reason=.
   const GURL url("chrome://chrome-signin/?access_point=0&reason=0");
   base::WeakPtr<InlineLoginHandlerImpl> handler;
   // MockSyncStarterInlineSigninHelper will delete itself when done using
   // base::ThreadTaskRunnerHandle::DeleteSoon(), so need to delete here.  But
   // do need the RunUntilIdle() at the end.
   MockSyncStarterInlineSigninHelper* helper =
       new MockSyncStarterInlineSigninHelper(
-          handler,
-          browser()->profile()->GetRequestContext(),
-          browser()->profile(),
-          url,
-          "foo@gmail.com",
-          "gaiaid-12345",
+          handler, browser()->profile()->GetRequestContext(),
+          browser()->profile(), url, "foo@gmail.com", "gaiaid-12345",
           "password",
-          "",  // session index
+          "",           // session index
           "auth_code",  // auth code
           std::string(),
-          true,  // choose what to sync
-          false);  // confirm untrusted signin
+          true,   // choose what to sync
+          false,  // confirm untrusted signin
+          false);
   EXPECT_CALL(*helper, CreateSyncStarter(
                            _, _, _, _, "refresh_token",
                            OneClickSigninSyncStarter::CURRENT_PROFILE,
                            OneClickSigninSyncStarter::CONFIGURE_SYNC_FIRST,
                            OneClickSigninSyncStarter::CONFIRM_AFTER_SIGNIN));
 
   SimulateOnClientOAuthSuccess(helper, "refresh_token");
   base::RunLoop().RunUntilIdle();
 }
 
 // Test signin helper creates sync starter with correct confirmation when
 // signing in with an untrusted sign occurs.
 IN_PROC_BROWSER_TEST_F(InlineLoginHelperBrowserTest,
                        SigninCreatesSyncStarter3) {
   // See Source enum in components/signin/core/browser/signin_metrics.h for
   // possible values of access_point=, reason=.
   GURL url("chrome://chrome-signin/?access_point=0&reason=0");
   base::WeakPtr<InlineLoginHandlerImpl> handler;
   // MockSyncStarterInlineSigninHelper will delete itself when done using
   // base::ThreadTaskRunnerHandle::DeleteSoon(), so need to delete here.  But
   // do need the RunUntilIdle() at the end.
   MockSyncStarterInlineSigninHelper* helper =
       new MockSyncStarterInlineSigninHelper(
-          handler,
-          browser()->profile()->GetRequestContext(),
-          browser()->profile(),
-          url,
-          "foo@gmail.com",
-          "gaiaid-12345",
+          handler, browser()->profile()->GetRequestContext(),
+          browser()->profile(), url, "foo@gmail.com", "gaiaid-12345",
           "password",
-          "",  // session index
+          "",           // session index
           "auth_code",  // auth code
           std::string(),
           false,  // choose what to sync
-          true);  // confirm untrusted signin
+          true,   // confirm untrusted signin
+          false);
   EXPECT_CALL(
       *helper,
       CreateSyncStarter(_, _, _, _, "refresh_token",
                         OneClickSigninSyncStarter::CURRENT_PROFILE,
                         OneClickSigninSyncStarter::CONFIRM_SYNC_SETTINGS_FIRST,
                         OneClickSigninSyncStarter::CONFIRM_UNTRUSTED_SIGNIN));
 
   SimulateOnClientOAuthSuccess(helper, "refresh_token");
   base::RunLoop().RunUntilIdle();
 }
 
 // Test signin helper creates sync starter with correct confirmation during
 // re-auth.
 IN_PROC_BROWSER_TEST_F(InlineLoginHelperBrowserTest,
                        SigninCreatesSyncStarter4) {
   // See Source enum in components/signin/core/browser/signin_metrics.h for
   // possible values of access_point=, reason=.
   const GURL url("chrome://chrome-signin/?access_point=3&reason=0");
   base::WeakPtr<InlineLoginHandlerImpl> handler;
   // MockSyncStarterInlineSigninHelper will delete itself when done using
   // base::ThreadTaskRunnerHandle::DeleteSoon(), so need to delete here.  But
   // do need the RunUntilIdle() at the end.
   MockSyncStarterInlineSigninHelper* helper =
       new MockSyncStarterInlineSigninHelper(
-          handler,
-          browser()->profile()->GetRequestContext(),
-          browser()->profile(),
-          url,
-          "foo@gmail.com",
-          "gaiaid-12345",
+          handler, browser()->profile()->GetRequestContext(),
+          browser()->profile(), url, "foo@gmail.com", "gaiaid-12345",
           "password",
-          "",  // session index
+          "",           // session index
           "auth_code",  // auth code
           std::string(),
           false,  // choose what to sync
-          false);  // confirm untrusted signin
+          false,  // confirm untrusted signin
+          false);
 
   // Even though "choose what to sync" is false, the source of the URL is
   // settings, which means the user wants to CONFIGURE_SYNC_FIRST.
   EXPECT_CALL(*helper, CreateSyncStarter(
                            _, _, _, _, "refresh_token",
                            OneClickSigninSyncStarter::CURRENT_PROFILE,
                            OneClickSigninSyncStarter::CONFIGURE_SYNC_FIRST,
                            OneClickSigninSyncStarter::CONFIRM_AFTER_SIGNIN));
 
   SimulateOnClientOAuthSuccess(helper, "refresh_token");
   base::RunLoop().RunUntilIdle();
 }
 
 // Test signin helper does not create sync starter when reauthenticating.
 IN_PROC_BROWSER_TEST_F(InlineLoginHelperBrowserTest,
                        ReauthCallsUpdateCredentials) {
   ASSERT_EQ(0ul, token_service()->GetAccounts().size());
 
   // See Source enum in components/signin/core/browser/signin_metrics.h for
   // possible values of access_point=, reason=.
   GURL url("chrome://chrome-signin/?access_point=3&reason=2");
   base::WeakPtr<InlineLoginHandlerImpl> handler;
   InlineSigninHelper helper(handler, browser()->profile()->GetRequestContext(),
                             browser()->profile(),
                             Profile::CreateStatus::CREATE_STATUS_INITIALIZED,
                             url, "foo@gmail.com", "gaiaid-12345", "password",
                             "",           // session index
                             "auth_code",  // auth code
                             std::string(),
-                            false,   // choose what to sync
-                            false);  // confirm untrusted signin
+                            false,  // choose what to sync
+                            false,  // confirm untrusted signin
+                            false);
   SimulateOnClientOAuthSuccess(&helper, "refresh_token");
   ASSERT_EQ(1ul, token_service()->GetAccounts().size());
   base::RunLoop().RunUntilIdle();
 }
 
 // Test signin helper does not create sync starter when adding another account
 // to profile.
 IN_PROC_BROWSER_TEST_F(InlineLoginHelperBrowserTest,
                        AddAccountsCallsUpdateCredentials) {
   ASSERT_EQ(0ul, token_service()->GetAccounts().size());
 
   // See Source enum in components/signin/core/browser/signin_metrics.h for
   // possible values of access_point=, reason=.
   GURL url("chrome://chrome-signin/?access_point=10&reason=1");
   base::WeakPtr<InlineLoginHandlerImpl> handler;
   InlineSigninHelper helper(handler, browser()->profile()->GetRequestContext(),
                             browser()->profile(),
                             Profile::CreateStatus::CREATE_STATUS_INITIALIZED,
                             url, "foo@gmail.com", "gaiaid-12345", "password",
                             "",           // session index
                             "auth_code",  // auth code
                             std::string(),
-                            false,   // choose what to sync
-                            false);  // confirm untrusted signin
+                            false,  // choose what to sync
+                            false,  // confirm untrusted signin
+                            false);
   SimulateOnClientOAuthSuccess(&helper, "refresh_token");
   ASSERT_EQ(1ul, token_service()->GetAccounts().size());
   base::RunLoop().RunUntilIdle();
 }
 
+IN_PROC_BROWSER_TEST_F(InlineLoginHelperBrowserTest,
+                       ForceSigninWithUserManager) {
+  GURL url("chrome://chrome-signin/?access_point=0&reason=0");
+  base::WeakPtr<InlineLoginHandlerImpl> handler;
+  // MockSyncStarterInlineSigninHelper will delete itself when done using
+  // base::ThreadTaskRunnerHandle::DeleteSoon(), so need to delete here.  But
+  // do need the RunUntilIdle() at the end.
+  MockSyncStarterInlineSigninHelper* helper =
+      new MockSyncStarterInlineSigninHelper(
+          handler, browser()->profile()->GetRequestContext(),
+          browser()->profile(), url, "foo@gmail.com", "gaiaid-12345",
+          "password", "", "auth_code", std::string(), false, false, true);
+  EXPECT_CALL(
+      *helper,
+      CreateSyncStarter(_, _, _, _, "refresh_token",
+                        OneClickSigninSyncStarter::CURRENT_PROFILE,
+                        OneClickSigninSyncStarter::CONFIRM_SYNC_SETTINGS_FIRST,
+                        OneClickSigninSyncStarter::CONFIRM_AFTER_SIGNIN));
+
+  ProfileAttributesEntry* entry;
+  ASSERT_TRUE(g_browser_process->profile_manager()
+                  ->GetProfileAttributesStorage()
+                  .GetProfileAttributesWithPath(browser()->profile()->GetPath(),
+                                                &entry));
+  entry->SetIsSigninRequired(true);
+
+  ASSERT_EQ(1ul, BrowserList::GetInstance()->size());
+  SimulateOnClientOAuthSuccess(helper, "refresh_token");
+  base::RunLoop().RunUntilIdle();
+  ASSERT_EQ(2ul, BrowserList::GetInstance()->size());
+  ASSERT_FALSE(entry->IsSigninRequired());
+}
+
 class InlineLoginUISafeIframeBrowserTest : public InProcessBrowserTest {
  public:
   FooWebUIProvider& foo_provider() { return foo_provider_; }
 
  private:
   void SetUp() override {
     // Don't spin up the IO thread yet since no threads are allowed while
     // spawning sandbox host process. See crbug.com/322732.
     ASSERT_TRUE(embedded_test_server()->InitializeAndListen());
 
@@ skipping 79 matching lines @@
   content::WebContents* contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   ASSERT_TRUE(content::ExecuteScript(
       contents, "window.location.href = 'chrome://foo'"));
 
   content::TestNavigationObserver navigation_observer(contents, 1);
   navigation_observer.Wait();
 
   EXPECT_EQ(GURL("about:blank"), contents->GetVisibleURL());
 }