OfflineAudioContext: add missing suspendIfNeeded() call.

OfflineAudioContext: add missing suspendIfNeeded() call.

R=haraken,rtoy
BUG=704012
Review-Url: https://codereview.chromium.org/2760323002
Cr-Commit-Position: refs/heads/master@{#458656}
Committed: https://chromium.googlesource.com/chromium/src/+/8c49908782266ac97dd687faf89ad10804db108b

[sof, 2017-03-21 14:41:38]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 14:41:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2017-03-21 14:43:00]

sigbjornf@opera.com changed reviewers:
+ haraken@chromium.org, rtoy@chromium.org

[sof, 2017-03-21 14:43:00]

please take a look.

e.g.,
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_11_...

[haraken, 2017-03-21 15:09:05]

LGTM

[Raymond Toy, 2017-03-21 15:29:48]

https://codereview.chromium.org/2760323002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp (right):

https://codereview.chromium.org/2760323002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp:87:
context->suspendIfNeeded();
AudioContext::create calls suspendIfNeeded() too.  Are both necessary?

[sof, 2017-03-21 15:44:35]

https://codereview.chromium.org/2760323002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp (right):

https://codereview.chromium.org/2760323002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp:87:
context->suspendIfNeeded();
On 2017/03/21 15:29:48, Raymond Toy wrote:
> AudioContext::create calls suspendIfNeeded() too.  Are both necessary?

No, not at all - thanks for pointing that out.

I misunderstood the stack, the problem enters due to
OfflineAudioContext::create()'s extra leaving early case (after r458087.)
Updated.

[sof, 2017-03-21 15:44:40]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 15:45:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2017-03-21 15:45:09]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-03-21 17:10:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 17:10:17]

Dry run: This issue passed the CQ dry run.

[sof, 2017-03-21 18:19:11]

Description was changed from

==========
BaseAudioContext: add missing suspendIfNeeded() call.

R=
BUG=
==========

to

==========
OfflineAudioContext: add missing suspendIfNeeded() call.

R=
BUG=
==========

[sof, 2017-03-21 18:19:56]

updated title to match

[Raymond Toy, 2017-03-21 20:06:03]

lgtm

[Raymond Toy, 2017-03-21 21:32:02]

BTW, is there an associated bug for this?

I just noticed now that I'm getting crashes locally with a debug build today. 
Don't remember seeing these a few days ago.  The stack is:

STDERR: [1:1:0321/142703.673475:3043474851889:FATAL:SuspendableObject.cpp(51)]
Check failed: m_suspendIfNeededCalled. 
STDERR: #0 0x7f81395d8cfb base::debug::StackTrace::StackTrace()
STDERR: #1 0x7f81395d738c base::debug::StackTrace::StackTrace()
STDERR: #2 0x7f813964527f logging::LogMessage::~LogMessage()
STDERR: #3 0x7f812f549380 blink::SuspendableObject::~SuspendableObject()
STDERR: #4 0x7f812de07aaa blink::BaseAudioContext::~BaseAudioContext()
STDERR: #5 0x7f812de34ec5 blink::OfflineAudioContext::~OfflineAudioContext()
STDERR: #6 0x7f812d2ad204
blink::GarbageCollectedFinalized<>::finalizeGarbageCollectedObject()

[sof, 2017-03-22 06:28:14]

Description was changed from

==========
OfflineAudioContext: add missing suspendIfNeeded() call.

R=
BUG=
==========

to

==========
OfflineAudioContext: add missing suspendIfNeeded() call.

R=haraken,rtoy
BUG=704012
==========

[sof, 2017-03-22 06:30:53]

On 2017/03/21 21:32:02, Raymond Toy wrote:
> BTW, is there an associated bug for this?
> 

Created crbug.com/704012

> I just noticed now that I'm getting crashes locally with a debug build today. 
> Don't remember seeing these a few days ago.  The stack is:
> 
> STDERR: [1:1:0321/142703.673475:3043474851889:FATAL:SuspendableObject.cpp(51)]
> Check failed: m_suspendIfNeededCalled. 
> STDERR: #0 0x7f81395d8cfb base::debug::StackTrace::StackTrace()
> STDERR: #1 0x7f81395d738c base::debug::StackTrace::StackTrace()
> STDERR: #2 0x7f813964527f logging::LogMessage::~LogMessage()
> STDERR: #3 0x7f812f549380 blink::SuspendableObject::~SuspendableObject()
> STDERR: #4 0x7f812de07aaa blink::BaseAudioContext::~BaseAudioContext()
> STDERR: #5 0x7f812de34ec5 blink::OfflineAudioContext::~OfflineAudioContext()
> STDERR: #6 0x7f812d2ad204
> blink::GarbageCollectedFinalized<>::finalizeGarbageCollectedObject()

It's the same one, I jumped over ~OfflineAudioContext when reading the stack
initially.

Introduced via the early return at the bottom
https://codereview.chromium.org/2758783002/patch/60001/70003

[sof, 2017-03-22 06:31:01]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2017-03-22 06:31:02]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2760323002/#ps40001
(title: "always call suspendIfNeeded() for OfflineAudioContexts")

[commit-bot: I haz the power, 2017-03-22 06:31:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 07:07:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490164261866750,
"parent_rev": "84290e6b3e01da65bc08ddf240771959083fbee4", "commit_rev":
"8c49908782266ac97dd687faf89ad10804db108b"}

[commit-bot: I haz the power, 2017-03-22 07:08:22]

Description was changed from

==========
OfflineAudioContext: add missing suspendIfNeeded() call.

R=haraken,rtoy
BUG=704012
==========

to

==========
OfflineAudioContext: add missing suspendIfNeeded() call.

R=haraken,rtoy
BUG=704012

Review-Url: https://codereview.chromium.org/2760323002
Cr-Commit-Position: refs/heads/master@{#458656}
Committed:
https://chromium.googlesource.com/chromium/src/+/8c49908782266ac97dd687faf89a...
==========

[commit-bot: I haz the power, 2017-03-22 07:08:24]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8c49908782266ac97dd687faf89a...