OfflineAudioContext: add missing suspendIfNeeded() call.

third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 64 matching lines @@
 #include "platform/audio/IIRFilter.h"
 #include "public/platform/Platform.h"
 #include "wtf/text/WTFString.h"
 
 namespace blink {
 
 BaseAudioContext* BaseAudioContext::create(
     Document& document,
     const AudioContextOptions& contextOptions,
     ExceptionState& exceptionState) {
-  return AudioContext::create(document, contextOptions, exceptionState);
+  BaseAudioContext* context =
+      AudioContext::create(document, contextOptions, exceptionState);
+  context->suspendIfNeeded();

[Raymond Toy, 2017/03/21 15:29:48]

AudioContext::create calls suspendIfNeeded() too.  Are both necessary?

[sof, 2017/03/21 15:44:35]

No, not at all - thanks for pointing that out.

I misunderstood the stack, the problem enters due to
OfflineAudioContext::create()'s extra leaving early case (after r458087.)
Updated.

+  return context;
 }
 
 // FIXME(dominicc): Devolve these constructors to AudioContext
 // and OfflineAudioContext respectively.
 
 // Constructor for rendering to the audio hardware.
 BaseAudioContext::BaseAudioContext(Document* document)
     : SuspendableObject(document),
       m_destinationNode(nullptr),
       m_isCleared(false),
@@ skipping 805 matching lines @@
 }
 
 SecurityOrigin* BaseAudioContext::getSecurityOrigin() const {
   if (getExecutionContext())
     return getExecutionContext()->getSecurityOrigin();
 
   return nullptr;
 }
 
 }  // namespace blink