Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: src/builtins/builtins-interpreter-gen.cc

Issue 2760233005: [snapshot] Move builtins generation into mksnapshot (Closed)
Patch Set: fix GYP builds Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins-interpreter.cc ('k') | src/builtins/setup-builtins-internal.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-interpreter-gen.cc
diff --git a/src/builtins/builtins-interpreter.cc b/src/builtins/builtins-interpreter-gen.cc
similarity index 57%
copy from src/builtins/builtins-interpreter.cc
copy to src/builtins/builtins-interpreter-gen.cc
index 3cfa57bcbe62d3beed4d4cdbc54c490a3383f461..90e6851f828201310524996d38c0d9c8ad4513b2 100644
--- a/src/builtins/builtins-interpreter.cc
+++ b/src/builtins/builtins-interpreter-gen.cc
@@ -1,37 +1,14 @@
-// Copyright 2016 the V8 project authors. All rights reserved.
+// Copyright 2017 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "src/builtins/builtins-utils.h"
#include "src/builtins/builtins.h"
-#include "src/objects-inl.h"
+#include "src/globals.h"
+#include "src/macro-assembler.h"
namespace v8 {
namespace internal {
-Handle<Code> Builtins::InterpreterPushArgsAndCall(
- TailCallMode tail_call_mode, InterpreterPushArgsMode mode) {
- switch (mode) {
- case InterpreterPushArgsMode::kJSFunction:
- if (tail_call_mode == TailCallMode::kDisallow) {
- return InterpreterPushArgsAndCallFunction();
- } else {
- return InterpreterPushArgsAndTailCallFunction();
- }
- case InterpreterPushArgsMode::kWithFinalSpread:
- CHECK(tail_call_mode == TailCallMode::kDisallow);
- return InterpreterPushArgsAndCallWithFinalSpread();
- case InterpreterPushArgsMode::kOther:
- if (tail_call_mode == TailCallMode::kDisallow) {
- return InterpreterPushArgsAndCall();
- } else {
- return InterpreterPushArgsAndTailCall();
- }
- }
- UNREACHABLE();
- return Handle<Code>::null();
-}
-
void Builtins::Generate_InterpreterPushArgsAndCall(MacroAssembler* masm) {
return Generate_InterpreterPushArgsAndCallImpl(
masm, TailCallMode::kDisallow, InterpreterPushArgsMode::kOther);
@@ -60,20 +37,6 @@ void Builtins::Generate_InterpreterPushArgsAndTailCallFunction(
masm, TailCallMode::kAllow, InterpreterPushArgsMode::kJSFunction);
}
-Handle<Code> Builtins::InterpreterPushArgsAndConstruct(
- InterpreterPushArgsMode mode) {
- switch (mode) {
- case InterpreterPushArgsMode::kJSFunction:
- return InterpreterPushArgsAndConstructFunction();
- case InterpreterPushArgsMode::kWithFinalSpread:
- return InterpreterPushArgsAndConstructWithFinalSpread();
- case InterpreterPushArgsMode::kOther:
- return InterpreterPushArgsAndConstruct();
- }
- UNREACHABLE();
- return Handle<Code>::null();
-}
-
void Builtins::Generate_InterpreterPushArgsAndConstruct(MacroAssembler* masm) {
return Generate_InterpreterPushArgsAndConstructImpl(
masm, InterpreterPushArgsMode::kOther);
« no previous file with comments | « src/builtins/builtins-interpreter.cc ('k') | src/builtins/setup-builtins-internal.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698