You don't need to revert it. The fix is simple. Update the number in interfaces-expected.txt ...
3 years, 9 months ago
(2017-03-21 00:08:21 UTC)
#7
Message was sent while issue was closed.
You don't need to revert it. The fix is simple. Update the number in
interfaces-expected.txt will do. This fix enable more passing WPT tests in
Blink.
On Mar 20, 2017 19:12, <dimich@chromium.org> wrote:
> Reviewers: foolip_UTC9_slow, loonybear
> CL: https://codereview.chromium.org/2760173002/
>
> Message:
> Created Revert of Make initEvent's first argument non-optional
>
> Description:
> Revert of Make initEvent's first argument non-optional (patchset #4
> id:60001 of
> https://codereview.chromium.org/2579993002/ )
>
> Reason for revert:
> It looks this broke the external/wpt/dom/interfaces.html test:
>
> https://uberchromegw.corp.google.com/i/chromium.webkit/
> builders/WebKit%20Mac10.12/builds/448
> https://uberchromegw.corp.google.com/i/chromium.webkit/
> builders/WebKit%20Mac10.12/builds/438
> ...
>
> Original issue's description:
> > Make initEvent's first argument non-optional
> >
> > https://github.com/whatwg/dom/issues/387
> >
> > BUG=673698
> >
> > Review-Url: https://codereview.chromium.org/2579993002
> > Cr-Commit-Position: refs/heads/master@{#458108}
> > Committed:
> https://chromium.googlesource.com/chromium/src/+/
> 2948f11e04fba5f0dc7244229c542152c97c1624
>
> TBR=foolip@chromium.org,lunalu@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=673698
>
> Affected files (+32, -4860 lines):
> A third_party/WebKit/LayoutTests/external/wpt/dom/events/Event-initEvent-
> expected.txt
> M third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt
> D third_party/WebKit/LayoutTests/platform/mac-mac10.11/external/wpt/dom/
> interfaces-expected.txt
> D third_party/WebKit/LayoutTests/platform/mac-retina/external/wpt/dom/
> events/Event-initEvent-expected.txt
> D third_party/WebKit/LayoutTests/platform/mac-retina/external/wpt/dom/
> interfaces-expected.txt
> D third_party/WebKit/LayoutTests/platform/win/external/wpt/dom/interfaces-
> expected.txt
> M third_party/WebKit/Source/core/events/Event.idl
>
>
>
--
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.
lunalu1
You don't need to revert it. The fix is simple. Update the number in interfaces-expected.txt ...
3 years, 9 months ago
(2017-03-21 00:08:22 UTC)
#8
Message was sent while issue was closed.
You don't need to revert it. The fix is simple. Update the number in
interfaces-expected.txt will do. This fix enable more passing WPT tests in
Blink.
On Mar 20, 2017 19:12, <dimich@chromium.org> wrote:
> Reviewers: foolip_UTC9_slow, loonybear
> CL: https://codereview.chromium.org/2760173002/
>
> Message:
> Created Revert of Make initEvent's first argument non-optional
>
> Description:
> Revert of Make initEvent's first argument non-optional (patchset #4
> id:60001 of
> https://codereview.chromium.org/2579993002/ )
>
> Reason for revert:
> It looks this broke the external/wpt/dom/interfaces.html test:
>
> https://uberchromegw.corp.google.com/i/chromium.webkit/
> builders/WebKit%20Mac10.12/builds/448
> https://uberchromegw.corp.google.com/i/chromium.webkit/
> builders/WebKit%20Mac10.12/builds/438
> ...
>
> Original issue's description:
> > Make initEvent's first argument non-optional
> >
> > https://github.com/whatwg/dom/issues/387
> >
> > BUG=673698
> >
> > Review-Url: https://codereview.chromium.org/2579993002
> > Cr-Commit-Position: refs/heads/master@{#458108}
> > Committed:
> https://chromium.googlesource.com/chromium/src/+/
> 2948f11e04fba5f0dc7244229c542152c97c1624
>
> TBR=foolip@chromium.org,lunalu@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=673698
>
> Affected files (+32, -4860 lines):
> A third_party/WebKit/LayoutTests/external/wpt/dom/events/Event-initEvent-
> expected.txt
> M third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt
> D third_party/WebKit/LayoutTests/platform/mac-mac10.11/external/wpt/dom/
> interfaces-expected.txt
> D third_party/WebKit/LayoutTests/platform/mac-retina/external/wpt/dom/
> events/Event-initEvent-expected.txt
> D third_party/WebKit/LayoutTests/platform/mac-retina/external/wpt/dom/
> interfaces-expected.txt
> D third_party/WebKit/LayoutTests/platform/win/external/wpt/dom/interfaces-
> expected.txt
> M third_party/WebKit/Source/core/events/Event.idl
>
>
>
--
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.
Issue 2760173002: Revert of Make initEvent's first argument non-optional
(Closed)
Created 3 years, 9 months ago by Dmitry Titov
Modified 3 years, 9 months ago
Reviewers: foolip, lunalu1
Base URL:
Comments: 0