Make initEvent's first argument non-optional

Make initEvent's first argument non-optional

https://github.com/whatwg/dom/issues/387

BUG=673698
Review-Url: https://codereview.chromium.org/2579993002
Cr-Original-Commit-Position: refs/heads/master@{#458108}
Committed: https://chromium.googlesource.com/chromium/src/+/2948f11e04fba5f0dc7244229c542152c97c1624
Review-Url: https://codereview.chromium.org/2579993002
Cr-Commit-Position: refs/heads/master@{#458443}
Committed: https://chromium.googlesource.com/chromium/src/+/f23d7fd62a4239f5cd2498129b4aeadac32984c3

[lunalu1, 2016-12-16 14:25:45]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 14:26:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 15:19:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 15:19:09]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[lunalu1, 2017-01-06 20:41:33]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 20:41:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 21:50:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 21:50:47]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Rick Byers, 2017-01-31 00:27:50]

What's the status of this one?  The logs are gone now so I'm not sure what was
failing.

[lunalu1, 2017-03-11 18:34:38]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 18:34:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 19:08:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 19:08:08]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[lunalu1, 2017-03-15 19:19:46]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 19:20:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lunalu1, 2017-03-15 19:54:35]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 19:55:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lunalu1, 2017-03-15 19:55:24]

lunalu@chromium.org changed reviewers:
+ foolip@chromium.org

[lunalu1, 2017-03-15 19:55:24]

Updated EventInit to match the spec. PTAL

[commit-bot: I haz the power, 2017-03-15 21:34:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 21:34:01]

Dry run: This issue passed the CQ dry run.

[foolip, 2017-03-19 02:25:00]

The CQ bit was checked by foolip@chromium.org

[foolip, 2017-03-19 02:25:00]

lgtm

[commit-bot: I haz the power, 2017-03-19 02:25:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[foolip, 2017-03-19 02:26:01]

Description was changed from

==========
Update EventInit attributes to be non optional

BUG=673698
==========

to

==========
Make initEvent's first argument non-optional

BUG=673698
==========

[foolip, 2017-03-19 02:26:24]

Description was changed from

==========
Make initEvent's first argument non-optional

BUG=673698
==========

to

==========
Make initEvent's first argument non-optional

https://github.com/whatwg/dom/issues/387

BUG=673698
==========

[commit-bot: I haz the power, 2017-03-19 02:27:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-19 02:27:21]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[lunalu1, 2017-03-20 14:47:14]

The CQ bit was checked by lunalu@chromium.org

[lunalu1, 2017-03-20 14:47:14]

The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2579993002/#ps60001
(title: "Rebase update")

[commit-bot: I haz the power, 2017-03-20 14:47:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 17:24:44]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490021234327770,
"parent_rev": "2fb2a7435bb358918edffdbd5209a12b19fda7ab", "commit_rev":
"2948f11e04fba5f0dc7244229c542152c97c1624"}

[commit-bot: I haz the power, 2017-03-20 17:25:22]

Description was changed from

==========
Make initEvent's first argument non-optional

https://github.com/whatwg/dom/issues/387

BUG=673698
==========

to

==========
Make initEvent's first argument non-optional

https://github.com/whatwg/dom/issues/387

BUG=673698

Review-Url: https://codereview.chromium.org/2579993002
Cr-Commit-Position: refs/heads/master@{#458108}
Committed:
https://chromium.googlesource.com/chromium/src/+/2948f11e04fba5f0dc7244229c54...
==========

[commit-bot: I haz the power, 2017-03-20 17:25:23]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2948f11e04fba5f0dc7244229c54...

[Dmitry Titov, 2017-03-20 23:12:55]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2760173002/ by dimich@chromium.org.

The reason for reverting is: It looks this broke the
external/wpt/dom/interfaces.html test:

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac1...
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac1...
....

[lunalu1, 2017-03-21 00:07:14]

Yeah but that's an easy fix. You just need to update the failing and
passing tests.

On Mar 20, 2017 19:12, <dimich@chromium.org> wrote:

> A revert of this CL (patchset #4 id:60001) has been created in
> https://codereview.chromium.org/2760173002/ by dimich@chromium.org.
>
> The reason for reverting is: It looks this broke the
> external/wpt/dom/interfaces.html test:
>
> https://uberchromegw.corp.google.com/i/chromium.webkit/
> builders/WebKit%20Mac10.12/builds/448
> https://uberchromegw.corp.google.com/i/chromium.webkit/
> builders/WebKit%20Mac10.12/builds/438
> ....
>
> https://codereview.chromium.org/2579993002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[lunalu1, 2017-03-21 00:07:16]

Yeah but that's an easy fix. You just need to update the failing and
passing tests.

On Mar 20, 2017 19:12, <dimich@chromium.org> wrote:

> A revert of this CL (patchset #4 id:60001) has been created in
> https://codereview.chromium.org/2760173002/ by dimich@chromium.org.
>
> The reason for reverting is: It looks this broke the
> external/wpt/dom/interfaces.html test:
>
> https://uberchromegw.corp.google.com/i/chromium.webkit/
> builders/WebKit%20Mac10.12/builds/448
> https://uberchromegw.corp.google.com/i/chromium.webkit/
> builders/WebKit%20Mac10.12/builds/438
> ....
>
> https://codereview.chromium.org/2579993002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[foolip, 2017-03-21 02:21:45]

On 2017/03/21 00:07:16, loonybear wrote:
> Yeah but that's an easy fix. You just need to update the failing and
> passing tests.
> 
> On Mar 20, 2017 19:12, <mailto:dimich@chromium.org> wrote:
> 
> > A revert of this CL (patchset #4 id:60001) has been created in
> > https://codereview.chromium.org/2760173002/ by mailto:dimich@chromium.org.
> >
> > The reason for reverting is: It looks this broke the
> > external/wpt/dom/interfaces.html test:
> >
> > https://uberchromegw.corp.google.com/i/chromium.webkit/
> > builders/WebKit%20Mac10.12/builds/448
> > https://uberchromegw.corp.google.com/i/chromium.webkit/
> > builders/WebKit%20Mac10.12/builds/438
> > ....
> >
> > https://codereview.chromium.org/2579993002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

There's probably some interfaces-expected.txt file which wasn't updated in this
CL.

[lunalu1, 2017-03-21 14:29:26]

On 2017/03/21 02:21:45, foolip_UTC9_slow wrote:
> On 2017/03/21 00:07:16, loonybear wrote:
> > Yeah but that's an easy fix. You just need to update the failing and
> > passing tests.
> > 
> > On Mar 20, 2017 19:12, <mailto:dimich@chromium.org> wrote:
> > 
> > > A revert of this CL (patchset #4 id:60001) has been created in
> > > https://codereview.chromium.org/2760173002/ by mailto:dimich@chromium.org.
> > >
> > > The reason for reverting is: It looks this broke the
> > > external/wpt/dom/interfaces.html test:
> > >
> > > https://uberchromegw.corp.google.com/i/chromium.webkit/
> > > builders/WebKit%20Mac10.12/builds/448
> > > https://uberchromegw.corp.google.com/i/chromium.webkit/
> > > builders/WebKit%20Mac10.12/builds/438
> > > ....
> > >
> > > https://codereview.chromium.org/2579993002/
> > >
> > 
> > -- 
> > You received this message because you are subscribed to the Google Groups
> > "Chromium-reviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:chromium-reviews+unsubscribe@chromium.org.
> 
> There's probably some interfaces-expected.txt file which wasn't updated in
this
> CL.

Maybe it wasn't up-to-date the moment I submitted it. I will patch this and land
it again.

[lunalu1, 2017-03-21 15:02:07]

lunalu@chromium.org changed reviewers:
+ dimich@chromium.org

[lunalu1, 2017-03-21 15:02:07]

Bug is fixed. PTAL

[lunalu1, 2017-03-21 15:02:43]

Description was changed from

==========
Make initEvent's first argument non-optional

https://github.com/whatwg/dom/issues/387

BUG=673698

Review-Url: https://codereview.chromium.org/2579993002
Cr-Commit-Position: refs/heads/master@{#458108}
Committed:
https://chromium.googlesource.com/chromium/src/+/2948f11e04fba5f0dc7244229c54...
==========

to

==========
Make initEvent's first argument non-optional

https://github.com/whatwg/dom/issues/387

BUG=673698

Review-Url: https://codereview.chromium.org/2579993002
Cr-Commit-Position: refs/heads/master@{#458108}
Committed:
https://chromium.googlesource.com/chromium/src/+/2948f11e04fba5f0dc7244229c54...
==========

[lunalu1, 2017-03-21 15:02:51]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 15:03:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[foolip, 2017-03-21 15:07:37]

lgtm

[commit-bot: I haz the power, 2017-03-21 16:36:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 16:36:58]

Dry run: This issue passed the CQ dry run.

[lunalu1, 2017-03-21 16:49:29]

The CQ bit was checked by lunalu@chromium.org

[commit-bot: I haz the power, 2017-03-21 16:50:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 16:59:22]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490114969786740,
"parent_rev": "8f66fbdfa04ed973cd6d7ec81a463efe0561b612", "commit_rev":
"f23d7fd62a4239f5cd2498129b4aeadac32984c3"}

[commit-bot: I haz the power, 2017-03-21 17:01:17]

Description was changed from

==========
Make initEvent's first argument non-optional

https://github.com/whatwg/dom/issues/387

BUG=673698

Review-Url: https://codereview.chromium.org/2579993002
Cr-Commit-Position: refs/heads/master@{#458108}
Committed:
https://chromium.googlesource.com/chromium/src/+/2948f11e04fba5f0dc7244229c54...
==========

to

==========
Make initEvent's first argument non-optional

https://github.com/whatwg/dom/issues/387

BUG=673698

Review-Url: https://codereview.chromium.org/2579993002
Cr-Original-Commit-Position: refs/heads/master@{#458108}
Committed:
https://chromium.googlesource.com/chromium/src/+/2948f11e04fba5f0dc7244229c54...
Review-Url: https://codereview.chromium.org/2579993002
Cr-Commit-Position: refs/heads/master@{#458443}
Committed:
https://chromium.googlesource.com/chromium/src/+/f23d7fd62a4239f5cd2498129b4a...
==========

[commit-bot: I haz the power, 2017-03-21 17:01:20]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/f23d7fd62a4239f5cd2498129b4a...