content/public/android/java/src/org/chromium/content/common/IContentChildProcessCallback.aidl - Issue 2760093002: Making callbacks in Android ChildProcessLauncher generic.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/android/java/src/org/chromium/content/common/IContentChildProcessCallback.aidl

Issue 2760093002: Making callbacks in Android ChildProcessLauncher generic. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/common/IChildProcessService.aidl ('k') | content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2012 The Chromium Authors. All rights reserved.	1 // Copyright 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 package org.chromium.content.common;	5 package org.chromium.content.common;

6	6

7 import org.chromium.content.common.SurfaceWrapper;	7 import org.chromium.content.common.SurfaceWrapper;

8 import android.view.Surface;	8 import android.view.Surface;

9	9

10 interface IChildProcessCallback {	10 interface IContentChildProcessCallback {
	boliu 2017/03/20 22:39:16 Let's bikeshed the name.. this is now only about S Let's bikeshed the name.. this is now only about Surfaces, so maybe something surface related? Err... SurfaceChannel? Jay Civelli 2017/03/20 22:41:57 Actually I was thinking about this when I sent it Show quoted text On 2017/03/20 22:39:16, boliu wrote: > Let's bikeshed the name.. this is now only about Surfaces, so maybe something > surface related? Err... SurfaceChannel? Actually I was thinking about this when I sent it for review. My take is that it's the callbacks for the GPU process, since it's process specific maybe IGpuProcessCallbacks? WDYT? boliu 2017/03/20 22:45:48 sgtm Show quoted text On 2017/03/20 22:41:57, Jay Civelli wrote: > On 2017/03/20 22:39:16, boliu wrote: > > Let's bikeshed the name.. this is now only about Surfaces, so maybe something > > surface related? Err... SurfaceChannel? > > Actually I was thinking about this when I sent it for review. > My take is that it's the callbacks for the GPU process, since it's process > specific maybe IGpuProcessCallbacks? > WDYT? sgtm
11	11

12 void forwardSurfaceForSurfaceRequest(	12 void forwardSurfaceForSurfaceRequest(

13 in UnguessableToken requestToken, in Surface surface);	13 in UnguessableToken requestToken, in Surface surface);

14	14

15 SurfaceWrapper getViewSurface(int surfaceId);	15 SurfaceWrapper getViewSurface(int surfaceId);

16 }	16 }

OLD	NEW