Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2760073003:
[GPU Workaround] Re-enable disable_chromium_framebuffer_multisample on Nexus 7g2 and alike (Closed)
Description[GPU Workaround] Re-enable disable_chromium_framebuffer_multisample on Nexus 7g2 and alike
Somehow it has an interaction with the other workaround
force_update_scissor_state_when_binding_fbo0, disabling it would make
https://crbug.com/670607 to repro again. This CL re-enables it.
WebGL2 support on those devices are disabled as well.
BUG=698197
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2760073003
Cr-Commit-Position: refs/heads/master@{#459965}
Committed: https://chromium.googlesource.com/chromium/src/+/06be3b5e0202f6c0b4aa4fc331e74ceada3f18ba
Patch Set 1 #Patch Set 2 : +sw list #
Messages
Total messages: 22 (13 generated)
Description was changed from ========== [GPU Workaround] Re-enable disable_chromium_framebuffer_multisample on Qualcomm Somehow it has an interaction with the other workaround force_update_scissor_state_when_binding_fbo0, disabling it would make https://crbug.com/670607 to repro again. This CL re-enables it. BUG=698197 ========== to ========== [GPU Workaround] Re-enable disable_chromium_framebuffer_multisample on Qualcomm Somehow it has an interaction with the other workaround force_update_scissor_state_when_binding_fbo0, disabling it would make https://crbug.com/670607 to repro again. This CL re-enables it. BUG=698197 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
trchen@chromium.org changed reviewers: + kainino@chromium.org, zmo@chromium.org
Hello Kai, Do you know what's the context of CL https://codereview.chromium.org/2707623002 ? It is making a Nexus 7 gen.2 scissor workaround to fail. I investigated it but couldn't figure out how they interact. :( Should we make the workaround condition to (os_version < 6.0 || machine_model_name in ["Nexus 7", "KFTHWI", "KFSAWI", "KFAPWI", "KFTHWA", "KFSAWA", "KFAPWA"]) instead?
On 2017/03/21 00:02:21, trchen wrote: > Hello Kai, > > Do you know what's the context of CL https://codereview.chromium.org/2707623002 ? It is needed to pass a large number of WebGL 2.0 conformance tests. Without it, tons of WebGL 2 content breaks. > It is making a Nexus 7 gen.2 scissor workaround to fail. I investigated it but > couldn't figure out how they interact. :( Perhaps they interact via the framebuffer state: https://cs.chromium.org/chromium/src/gpu/command_buffer/service/feature_info.... With disable_chromium_framebuffer_multisample present, it's not possible to bind separate READ and DRAW framebuffers (for some reason). I don't know exactly how this could cause a problem, though. > Should we make the workaround condition to (os_version < 6.0 || > machine_model_name in ["Nexus 7", "KFTHWI", "KFSAWI", "KFAPWI", "KFTHWA", > "KFSAWA", "KFAPWA"]) instead? If this is done, we'll need to also disable WebGL 2 on those devices. See: https://codereview.chromium.org/2707623002/diff/80001/gpu/config/software_ren...
The CQ bit was checked by trchen@chromium.org to run a CQ dry run
Am I doing it right?
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
trchen: I think this makes sense, non-owner LGTM. zmo will need to review as well.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
aelias@chromium.org changed reviewers: + aelias@chromium.org
I have OWNERS on this directory as well, lgtm.
trchen: one last important thing I just noticed. Please update the title/description of the CL before submitting.
Description was changed from ========== [GPU Workaround] Re-enable disable_chromium_framebuffer_multisample on Qualcomm Somehow it has an interaction with the other workaround force_update_scissor_state_when_binding_fbo0, disabling it would make https://crbug.com/670607 to repro again. This CL re-enables it. BUG=698197 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [GPU Workaround] Re-enable disable_chromium_framebuffer_multisample on Nexus 7 gen.2 and alike Somehow it has an interaction with the other workaround force_update_scissor_state_when_binding_fbo0, disabling it would make https://crbug.com/670607 to repro again. This CL re-enables it. BUG=698197 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== [GPU Workaround] Re-enable disable_chromium_framebuffer_multisample on Nexus 7 gen.2 and alike Somehow it has an interaction with the other workaround force_update_scissor_state_when_binding_fbo0, disabling it would make https://crbug.com/670607 to repro again. This CL re-enables it. BUG=698197 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [GPU Workaround] Re-enable disable_chromium_framebuffer_multisample on Nexus 7g2 and alike Somehow it has an interaction with the other workaround force_update_scissor_state_when_binding_fbo0, disabling it would make https://crbug.com/670607 to repro again. This CL re-enables it. BUG=698197 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== [GPU Workaround] Re-enable disable_chromium_framebuffer_multisample on Nexus 7g2 and alike Somehow it has an interaction with the other workaround force_update_scissor_state_when_binding_fbo0, disabling it would make https://crbug.com/670607 to repro again. This CL re-enables it. BUG=698197 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [GPU Workaround] Re-enable disable_chromium_framebuffer_multisample on Nexus 7g2 and alike Somehow it has an interaction with the other workaround force_update_scissor_state_when_binding_fbo0, disabling it would make https://crbug.com/670607 to repro again. This CL re-enables it. WebGL2 support on those devices are disabled as well. BUG=698197 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by trchen@chromium.org
On 2017/03/27 23:14:28, Kai Ninomiya wrote: > trchen: one last important thing I just noticed. Please update the > title/description of the CL before submitting. Done. The CL description should be more accurate now.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490657541119910,
"parent_rev": "2f9bf057e1227bcee1d24e4b619894233946d26c", "commit_rev":
"06be3b5e0202f6c0b4aa4fc331e74ceada3f18ba"}
Message was sent while issue was closed.
Description was changed from ========== [GPU Workaround] Re-enable disable_chromium_framebuffer_multisample on Nexus 7g2 and alike Somehow it has an interaction with the other workaround force_update_scissor_state_when_binding_fbo0, disabling it would make https://crbug.com/670607 to repro again. This CL re-enables it. WebGL2 support on those devices are disabled as well. BUG=698197 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [GPU Workaround] Re-enable disable_chromium_framebuffer_multisample on Nexus 7g2 and alike Somehow it has an interaction with the other workaround force_update_scissor_state_when_binding_fbo0, disabling it would make https://crbug.com/670607 to repro again. This CL re-enables it. WebGL2 support on those devices are disabled as well. BUG=698197 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2760073003 Cr-Commit-Position: refs/heads/master@{#459965} Committed: https://chromium.googlesource.com/chromium/src/+/06be3b5e0202f6c0b4aa4fc331e7... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/06be3b5e0202f6c0b4aa4fc331e7... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
