Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2707623002:
Disable some old Qualcomm workarounds on new Android (Closed)
|
Created:
3 years, 10 months ago by Kai Ninomiya Modified:
3 years, 10 months ago CC:
chromium-reviews, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable some old Qualcomm workarounds on new Android
Workarounds disable_depth_texture and disable_chromium_framebuffer_multisample were added for old Qualcomm devices but work correctly on newer devices and are needed for WebGL 2.
This also un-disables GL_OES_depth_texture on these platforms.
Test note: The change in availability of MSAA causes the tests to access a different (currently non-existent) set of reference images on Qualcomm bots (_msaa.png to _non_msaa.png). This CL effectively creates a new configuration - which is why the tests do not need revisions incremented.
BUG=682075, 682753
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2707623002
Cr-Commit-Position: refs/heads/master@{#452748}
Committed: https://chromium.googlesource.com/chromium/src/+/5fa975c1785e2a47c96471691447846d1be8b51d
Patch Set 1 #Patch Set 2 : rebase, increment version, disable webgl2 on old qualcomm, update pixel expectations #Patch Set 3 : add another cr_bugs entry #
Total comments: 6
Patch Set 4 : fixes and cr_bugs #Patch Set 5 : rebase #
Messages
Total messages: 30 (20 generated)
Description was changed from ========== disable some old Qualcomm workarounds on new Android BUG=682753 ========== to ========== disable some old Qualcomm workarounds on new Android BUG=682753 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== disable some old Qualcomm workarounds on new Android BUG=682753 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Disable some old Qualcomm workarounds on new Android Workarounds disable_depth_texture and disable_chromium_framebuffer_multisample were added for old Qualcomm devices but work correctly on newer devices and are needed for WebGL 2. This also un-disables GL_OES_depth_texture on these platforms. COMMIT=false BUG=682753 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Disable some old Qualcomm workarounds on new Android Workarounds disable_depth_texture and disable_chromium_framebuffer_multisample were added for old Qualcomm devices but work correctly on newer devices and are needed for WebGL 2. This also un-disables GL_OES_depth_texture on these platforms. COMMIT=false BUG=682753 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Disable some old Qualcomm workarounds on new Android Workarounds disable_depth_texture and disable_chromium_framebuffer_multisample were added for old Qualcomm devices but work correctly on newer devices and are needed for WebGL 2. This also un-disables GL_OES_depth_texture on these platforms. *** TODO: - disable WebGL 2 on the same old Qualcomm; it won't work correctly. - test on some not-so-old devices like Nexus 6, ...? COMMIT=false *** BUG=682753 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Disable some old Qualcomm workarounds on new Android Workarounds disable_depth_texture and disable_chromium_framebuffer_multisample were added for old Qualcomm devices but work correctly on newer devices and are needed for WebGL 2. This also un-disables GL_OES_depth_texture on these platforms. *** TODO: - disable WebGL 2 on the same old Qualcomm; it won't work correctly. - test on some not-so-old devices like Nexus 6, ...? COMMIT=false *** BUG=682753 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Disable some old Qualcomm workarounds on new Android Workarounds disable_depth_texture and disable_chromium_framebuffer_multisample were added for old Qualcomm devices but work correctly on newer devices and are needed for WebGL 2. This also un-disables GL_OES_depth_texture on these platforms. *** TODO: - disable WebGL 2 on the same old Qualcomm; it won't work correctly. - test on some not-so-old devices like Nexus 6, ...? - works on Nexus 7 with Adreno 430 - update pixel test expectations COMMIT=false *** BUG=682753 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Disable some old Qualcomm workarounds on new Android Workarounds disable_depth_texture and disable_chromium_framebuffer_multisample were added for old Qualcomm devices but work correctly on newer devices and are needed for WebGL 2. This also un-disables GL_OES_depth_texture on these platforms. *** TODO: - disable WebGL 2 on the same old Qualcomm; it won't work correctly. - test on some not-so-old devices like Nexus 6, ...? - works on Nexus 7 with Adreno 430 - update pixel test expectations COMMIT=false *** BUG=682753 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Disable some old Qualcomm workarounds on new Android Workarounds disable_depth_texture and disable_chromium_framebuffer_multisample were added for old Qualcomm devices but work correctly on newer devices and are needed for WebGL 2. This also un-disables GL_OES_depth_texture on these platforms. *** TODO: - disable WebGL 2 on the same old Qualcomm; it won't work correctly. - test on some not-so-old devices like Nexus 6, ...? - works on Nexus 7 with Adreno 430 - update pixel test expectations COMMIT=false *** BUG=682753 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Disable some old Qualcomm workarounds on new Android Workarounds disable_depth_texture and disable_chromium_framebuffer_multisample were added for old Qualcomm devices but work correctly on newer devices and are needed for WebGL 2. This also un-disables GL_OES_depth_texture on these platforms. *** TODO: - disable WebGL 2 on the same old Qualcomm; it won't work correctly. - test on some not-so-old devices like Nexus 6, ...? - works on Nexus 7 with Adreno 430 - update pixel test expectations COMMIT=false *** BUG=682753 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Disable some old Qualcomm workarounds on new Android Workarounds disable_depth_texture and disable_chromium_framebuffer_multisample were added for old Qualcomm devices but work correctly on newer devices and are needed for WebGL 2. This also un-disables GL_OES_depth_texture on these platforms. BUG=682753 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Disable some old Qualcomm workarounds on new Android Workarounds disable_depth_texture and disable_chromium_framebuffer_multisample were added for old Qualcomm devices but work correctly on newer devices and are needed for WebGL 2. This also un-disables GL_OES_depth_texture on these platforms. BUG=682753 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Disable some old Qualcomm workarounds on new Android Workarounds disable_depth_texture and disable_chromium_framebuffer_multisample were added for old Qualcomm devices but work correctly on newer devices and are needed for WebGL 2. This also un-disables GL_OES_depth_texture on these platforms. Test note: The change in availability of MSAA causes the tests to access a different (currently non-existent) set of reference images on Qualcomm bots. This CL effectively creates a new configuration - which is why the tests do not need revisions incremented. BUG=682753 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
kainino@chromium.org changed reviewers: + kbr@chromium.org
Description was changed from ========== Disable some old Qualcomm workarounds on new Android Workarounds disable_depth_texture and disable_chromium_framebuffer_multisample were added for old Qualcomm devices but work correctly on newer devices and are needed for WebGL 2. This also un-disables GL_OES_depth_texture on these platforms. Test note: The change in availability of MSAA causes the tests to access a different (currently non-existent) set of reference images on Qualcomm bots. This CL effectively creates a new configuration - which is why the tests do not need revisions incremented. BUG=682753 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Disable some old Qualcomm workarounds on new Android Workarounds disable_depth_texture and disable_chromium_framebuffer_multisample were added for old Qualcomm devices but work correctly on newer devices and are needed for WebGL 2. This also un-disables GL_OES_depth_texture on these platforms. Test note: The change in availability of MSAA causes the tests to access a different (currently non-existent) set of reference images on Qualcomm bots (_msaa.png to _non_msaa.png). This CL effectively creates a new configuration - which is why the tests do not need revisions incremented. BUG=682753 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
kbr: PTAL zmo: FYI
Thanks Kai for tracking these down. A couple of concerns. https://codereview.chromium.org/2707623002/diff/40001/gpu/config/gpu_driver_b... File gpu/config/gpu_driver_bug_list_json.cc (left): https://codereview.chromium.org/2707623002/diff/40001/gpu/config/gpu_driver_b... gpu/config/gpu_driver_bug_list_json.cc:288: "id": 38, I don't think we can remove this entry wholesale. It affected rendering correctness on older devices. Was this an accident? If it was intentional, then we need to decide on an OS version and add an exception. https://codereview.chromium.org/2707623002/diff/40001/gpu/config/gpu_driver_b... File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2707623002/diff/40001/gpu/config/gpu_driver_b... gpu/config/gpu_driver_bug_list_json.cc:86: "description": "Disable depth textures on Android with Qualcomm GPUs", Please refer to the new bug ID here. It's better than not having a bug ID for this blacklist entry. https://codereview.chromium.org/2707623002/diff/40001/gpu/config/gpu_driver_b... gpu/config/gpu_driver_bug_list_json.cc:414: "cr_bugs": [449116, 471200, 612474], Please refer to the new bug ID here.
https://codereview.chromium.org/2707623002/diff/40001/gpu/config/gpu_driver_b... File gpu/config/gpu_driver_bug_list_json.cc (left): https://codereview.chromium.org/2707623002/diff/40001/gpu/config/gpu_driver_b... gpu/config/gpu_driver_bug_list_json.cc:288: "id": 38, On 2017/02/23 00:37:42, Ken Russell wrote: > I don't think we can remove this entry wholesale. It affected rendering > correctness on older devices. Was this an accident? If it was intentional, then > we need to decide on an OS version and add an exception. argh, I keep accidentally doing this. This entire removal is accidental, part of testing something else. https://codereview.chromium.org/2707623002/diff/40001/gpu/config/gpu_driver_b... File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2707623002/diff/40001/gpu/config/gpu_driver_b... gpu/config/gpu_driver_bug_list_json.cc:86: "description": "Disable depth textures on Android with Qualcomm GPUs", On 2017/02/23 00:37:42, Ken Russell wrote: > Please refer to the new bug ID here. It's better than not having a bug ID for > this blacklist entry. Done. https://codereview.chromium.org/2707623002/diff/40001/gpu/config/gpu_driver_b... gpu/config/gpu_driver_bug_list_json.cc:414: "cr_bugs": [449116, 471200, 612474], On 2017/02/23 00:37:42, Ken Russell wrote: > Please refer to the new bug ID here. Done.
Description was changed from ========== Disable some old Qualcomm workarounds on new Android Workarounds disable_depth_texture and disable_chromium_framebuffer_multisample were added for old Qualcomm devices but work correctly on newer devices and are needed for WebGL 2. This also un-disables GL_OES_depth_texture on these platforms. Test note: The change in availability of MSAA causes the tests to access a different (currently non-existent) set of reference images on Qualcomm bots (_msaa.png to _non_msaa.png). This CL effectively creates a new configuration - which is why the tests do not need revisions incremented. BUG=682753 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Disable some old Qualcomm workarounds on new Android Workarounds disable_depth_texture and disable_chromium_framebuffer_multisample were added for old Qualcomm devices but work correctly on newer devices and are needed for WebGL 2. This also un-disables GL_OES_depth_texture on these platforms. Test note: The change in availability of MSAA causes the tests to access a different (currently non-existent) set of reference images on Qualcomm bots (_msaa.png to _non_msaa.png). This CL effectively creates a new configuration - which is why the tests do not need revisions incremented. BUG=682075,682753 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Great. LGTM
On 2017/02/23 01:17:19, Ken Russell wrote: > Great. LGTM LGTM
The CQ bit was checked by kainino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kainino@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by kainino@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org, zmo@chromium.org Link to the patchset: https://codereview.chromium.org/2707623002/#ps80001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487905129222180,
"parent_rev": "7ee702e180915497ea80f4265a8754a3f3ae3570", "commit_rev":
"5fa975c1785e2a47c96471691447846d1be8b51d"}
Message was sent while issue was closed.
Description was changed from ========== Disable some old Qualcomm workarounds on new Android Workarounds disable_depth_texture and disable_chromium_framebuffer_multisample were added for old Qualcomm devices but work correctly on newer devices and are needed for WebGL 2. This also un-disables GL_OES_depth_texture on these platforms. Test note: The change in availability of MSAA causes the tests to access a different (currently non-existent) set of reference images on Qualcomm bots (_msaa.png to _non_msaa.png). This CL effectively creates a new configuration - which is why the tests do not need revisions incremented. BUG=682075,682753 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Disable some old Qualcomm workarounds on new Android Workarounds disable_depth_texture and disable_chromium_framebuffer_multisample were added for old Qualcomm devices but work correctly on newer devices and are needed for WebGL 2. This also un-disables GL_OES_depth_texture on these platforms. Test note: The change in availability of MSAA causes the tests to access a different (currently non-existent) set of reference images on Qualcomm bots (_msaa.png to _non_msaa.png). This CL effectively creates a new configuration - which is why the tests do not need revisions incremented. BUG=682075,682753 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2707623002 Cr-Commit-Position: refs/heads/master@{#452748} Committed: https://chromium.googlesource.com/chromium/src/+/5fa975c1785e2a47c96471691447... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/5fa975c1785e2a47c96471691447... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
