Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 2759713002: Media: replace HasActiveEffectivelyFullscreenVideo DCHECK with early return. (Closed)

Created:
1 year, 2 months ago by mlamouri (slow - plz ping)
Modified:
1 year, 2 months ago
Reviewers:
chcunningham
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, PEConn
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Media: replace HasActiveEffectivelyFullscreenVideo DCHECK with early return. BUG=702647 R=chcunningham@chromium.org Review-Url: https://codereview.chromium.org/2759713002 Cr-Commit-Position: refs/heads/master@{#458167} Committed: https://chromium.googlesource.com/chromium/src/+/fc7f323f548c926b99fe6ebd15f46a514f0df198

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M content/browser/media/media_web_contents_observer.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
mlamouri (slow - plz ping)
CC +peconn@ chcunningham@ PTAL :)
1 year, 2 months ago (2017-03-17 16:18:00 UTC) #3
chcunningham
lgtm
1 year, 2 months ago (2017-03-20 17:55:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759713002/1
1 year, 2 months ago (2017-03-20 18:23:07 UTC) #8
commit-bot: I haz the power
1 year, 2 months ago (2017-03-20 20:26:22 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fc7f323f548c926b99fe6ebd15f4...

Powered by Google App Engine
This is Rietveld 408576698