Chromium Code Reviews
Help | Chromium Project | Sign in
(5)

Issue 2759713002: Media: replace HasActiveEffectivelyFullscreenVideo DCHECK with early return. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 3 days ago by mlamouri
Modified:
1 week ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, PEConn
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Media: replace HasActiveEffectivelyFullscreenVideo DCHECK with early return. BUG=702647 R=chcunningham@chromium.org Review-Url: https://codereview.chromium.org/2759713002 Cr-Commit-Position: refs/heads/master@{#458167} Committed: https://chromium.googlesource.com/chromium/src/+/fc7f323f548c926b99fe6ebd15f46a514f0df198

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M content/browser/media/media_web_contents_observer.cc View 1 chunk +1 line, -3 lines 0 comments Download
Trybot results:  linux_chromium_asan_rel_ng   chromeos_amd64-generic_chromium_compile_only_ng   linux_chromium_compile_dbg_ng   win_chromium_compile_dbg_ng   cast_shell_android   linux_chromium_asan_rel_ng   ios-simulator-xcode-clang   linux_chromium_chromeos_rel_ng   android_n5x_swarming_rel   chromeos_amd64-generic_chromium_compile_only_ng   android_clang_dbg_recipe   cast_shell_linux   chromium_presubmit   android_arm64_dbg_recipe   linux_android_rel_ng   ios-simulator   win_chromium_x64_rel_ng   win_chromium_rel_ng   ios-device   linux_chromium_tsan_rel_ng   chromeos_daisy_chromium_compile_only_ng   android_compile_dbg   ios-device-xcode-clang   win_clang   linux_chromium_chromeos_ozone_rel_ng   mac_chromium_compile_dbg_ng   android_cronet   linux_chromium_rel_ng   mac_chromium_rel_ng   win_chromium_compile_dbg_ng   chromium_presubmit   cast_shell_android   cast_shell_linux   ios-simulator-xcode-clang   chromeos_daisy_chromium_compile_only_ng   ios-device   win_chromium_rel_ng   linux_chromium_rel_ng   mac_chromium_compile_dbg_ng   linux_chromium_compile_dbg_ng   ios-device-xcode-clang   linux_android_rel_ng   mac_chromium_rel_ng   linux_chromium_tsan_rel_ng   android_arm64_dbg_recipe   android_compile_dbg   chromeos_amd64-generic_chromium_compile_only_ng   android_cronet   linux_chromium_asan_rel_ng   win_chromium_x64_rel_ng   ios-simulator   linux_chromium_chromeos_ozone_rel_ng   android_clang_dbg_recipe   win_clang   android_n5x_swarming_rel   linux_chromium_chromeos_rel_ng 
Commit queue not available (can’t edit this change).

Messages

Total messages: 11 (7 generated)
mlamouri
CC +peconn@ chcunningham@ PTAL :)
1 week, 3 days ago (2017-03-17 16:18:00 UTC) #3
chcunningham_OOO_Mar27
lgtm
1 week ago (2017-03-20 17:55:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759713002/1
1 week ago (2017-03-20 18:23:07 UTC) #8
commit-bot: I haz the power
1 week ago (2017-03-20 20:26:22 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fc7f323f548c926b99fe6ebd15f4...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46