DevTools: add support for polling for coverage data in CSS agent

DevTools: add support for polling for coverage data in CSS agent

This adds takeCoverageDelta() which may be used to obtain newly
used rules plus used and unused rules from newly added styleshteets.

The data returned by CSS.stopRuleUsageTracking are now delta since
the last invocation of the above method.

Review-Url: https://codereview.chromium.org/2759703003
Cr-Commit-Position: refs/heads/master@{#459566}
Committed: https://chromium.googlesource.com/chromium/src/+/8a29ed05232f634a4ba33d1930a5c3ef8aaee0f5

[caseq, 2017-03-18 00:04:24]

caseq@chromium.org changed reviewers:
+ dgozman@chromium.org, lushnikov@chromium.org

[caseq, 2017-03-20 17:48:19]

caseq@chromium.org changed reviewers:
+ alph@chromium.org, pfeldman@chromium.org
- dgozman@chromium.org, lushnikov@chromium.org

[pfeldman, 2017-03-20 18:36:55]

protocol lgtm

[alph, 2017-03-20 20:48:31]

https://codereview.chromium.org/2759703003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/css/css-coverage-poll.html
(right):

https://codereview.chromium.org/2759703003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/css/css-coverage-poll.html:42:
if (!response.result) {
nit: if (result) dump...

https://codereview.chromium.org/2759703003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp (right):

https://codereview.chromium.org/2759703003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp:2486: bool used =
!!coverageDelta.take(styleRule);
contains

https://codereview.chromium.org/2759703003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp:2499:
HeapHashMap<Member<const StyleRule>, Member<CSSStyleRule>>::iterator it =
nit: auto it =

https://codereview.chromium.org/2759703003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h (right):

https://codereview.chromium.org/2759703003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h:353:
HeapVector<Member<InspectorStyleSheet>> m_coveragePendingStylsheets;
typo

[caseq, 2017-03-21 00:21:06]

ptal, altered as per Pavel's suggestions

[pfeldman, 2017-03-21 18:04:16]

Can we stop reporting zeros?

https://codereview.chromium.org/2759703003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/ElementRuleCollector.cpp (right):

https://codereview.chromium.org/2759703003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/ElementRuleCollector.cpp:382:
tracker->track(matchedRule.ruleData()->rule(),
nit: swap parameters :)

https://codereview.chromium.org/2759703003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/resolver/StyleRuleUsageTracker.cpp
(right):

https://codereview.chromium.org/2759703003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/resolver/StyleRuleUsageTracker.cpp:22: if
(!m_usedRules.insert(rule).isNewEntry)
This is not entirely correct due to stylesheetcontents content-based dedupe.

[caseq, 2017-03-23 00:24:51]

all done, ptal!

[pfeldman, 2017-03-24 00:46:38]

lgtm

[caseq, 2017-03-24 17:50:23]

The CQ bit was checked by caseq@chromium.org

[caseq, 2017-03-24 17:50:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2759703003/#ps60001
(title: "moved ranges sorting so it also works for CSS ranges")

[commit-bot: I haz the power, 2017-03-24 17:51:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 19:20:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 19:20:10]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[caseq, 2017-03-24 19:30:29]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2017-03-24 19:31:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 21:50:47]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490383829120190,
"parent_rev": "83bbe324e42ebe5b1205d6caeb1ea4149bad31f1", "commit_rev":
"8a29ed05232f634a4ba33d1930a5c3ef8aaee0f5"}

[commit-bot: I haz the power, 2017-03-24 21:51:36]

Description was changed from

==========
DevTools: add support for polling for coverage data in CSS agent

This adds takeCoverageDelta() which may be used to obtain newly
used rules plus used and unused rules from newly added styleshteets.

The data returned by CSS.stopRuleUsageTracking are now delta since
the last invocation of the above method.
==========

to

==========
DevTools: add support for polling for coverage data in CSS agent

This adds takeCoverageDelta() which may be used to obtain newly
used rules plus used and unused rules from newly added styleshteets.

The data returned by CSS.stopRuleUsageTracking are now delta since
the last invocation of the above method.

Review-Url: https://codereview.chromium.org/2759703003
Cr-Commit-Position: refs/heads/master@{#459566}
Committed:
https://chromium.googlesource.com/chromium/src/+/8a29ed05232f634a4ba33d1930a5...
==========

[commit-bot: I haz the power, 2017-03-24 21:51:37]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8a29ed05232f634a4ba33d1930a5...