Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: third_party/WebKit/Source/devtools/front_end/coverage/CoverageModel.js

Issue 2759703003: DevTools: add support for polling for coverage data in CSS agent (Closed)
Patch Set: moved ranges sorting so it also works for CSS ranges Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/inspector/browser_protocol.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/coverage/CoverageModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/coverage/CoverageModel.js b/third_party/WebKit/Source/devtools/front_end/coverage/CoverageModel.js
index 5864cbffd89d535d352a32edc432be30b8ef3e1d..8f339c9245527c394648340d5ea394704e677e3e 100644
--- a/third_party/WebKit/Source/devtools/front_end/coverage/CoverageModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/coverage/CoverageModel.js
@@ -72,7 +72,6 @@ Coverage.CoverageModel = class extends SDK.SDKModel {
for (var range of func.ranges)
ranges.push(range);
}
- ranges.sort((a, b) => a.startOffset - b.startOffset);
this._addCoverage(script, script.contentLength, script.lineOffset, script.columnOffset, ranges);
}
}
@@ -82,8 +81,9 @@ Coverage.CoverageModel = class extends SDK.SDKModel {
* @return {!Array<!Coverage.CoverageSegment>}
*/
static _convertToDisjointSegments(ranges) {
- var result = [];
+ ranges.sort((a, b) => a.startOffset - b.startOffset);
+ var result = [];
var stack = [];
for (var entry of ranges) {
var top = stack.peekLast();
« no previous file with comments | « third_party/WebKit/Source/core/inspector/browser_protocol.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698