Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2759533002: Remove legacy restart code (Closed)

Created:
3 years, 9 months ago by Cutch
Modified:
3 years, 9 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove legacy restart code Also fixes #29092 by threading Error objects back to the message handler. BUG= R=asiva@google.com, rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/a4adbffb50cde519bf36de5e1c674ac292dda413

Patch Set 1 #

Total comments: 3

Patch Set 2 : asiva review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -162 lines) Patch
M runtime/bin/error_exit.h View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/bin/gen_snapshot.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/main.cc View 4 chunks +1 line, -13 lines 0 comments Download
M runtime/include/dart_api.h View 2 chunks +1 line, -15 lines 0 comments Download
M runtime/lib/vmservice.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 1 chunk +0 lines, -27 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/service.status View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/service_kernel.status View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M runtime/vm/isolate.h View 2 chunks +1 line, -2 lines 0 comments Download
M runtime/vm/isolate.cc View 5 chunks +17 lines, -22 lines 0 comments Download
M runtime/vm/isolate_reload.cc View 1 chunk +10 lines, -9 lines 0 comments Download
M runtime/vm/object.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/object.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/object_service.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/service.h View 4 chunks +8 lines, -7 lines 0 comments Download
M runtime/vm/service.cc View 9 chunks +22 lines, -32 lines 0 comments Download
M runtime/vm/thread.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/thread.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Cutch
3 years, 9 months ago (2017-03-16 22:30:31 UTC) #3
rmacnak
lgtm https://codereview.chromium.org/2759533002/diff/1/runtime/bin/main.cc File runtime/bin/main.cc (right): https://codereview.chromium.org/2759533002/diff/1/runtime/bin/main.cc#newcode1633 runtime/bin/main.cc:1633: while (RunMainIsolate(script_name, &dart_options)) { Loop no longer needed.
3 years, 9 months ago (2017-03-16 22:45:28 UTC) #4
siva
lgtm. I like it when we delete code. https://codereview.chromium.org/2759533002/diff/1/runtime/vm/thread.cc File runtime/vm/thread.cc (right): https://codereview.chromium.org/2759533002/diff/1/runtime/vm/thread.cc#newcode277 runtime/vm/thread.cc:277: RawError* ...
3 years, 9 months ago (2017-03-16 23:02:30 UTC) #5
Cutch
Committed patchset #2 (id:20001) manually as a4adbffb50cde519bf36de5e1c674ac292dda413 (presubmit successful).
3 years, 9 months ago (2017-03-20 15:47:47 UTC) #7
Cutch
3 years, 9 months ago (2017-03-20 17:45:26 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/2759533002/diff/1/runtime/vm/thread.cc
File runtime/vm/thread.cc (right):

https://codereview.chromium.org/2759533002/diff/1/runtime/vm/thread.cc#newcod...
runtime/vm/thread.cc:277: RawError* Thread::get_and_clear_sticky_error() {
On 2017/03/16 23:02:30, siva wrote:
> NoSafepointScope here as a raw pointer is being held across multiple lines of
> code.

Done.

Powered by Google App Engine
This is Rietveld 408576698