Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: runtime/bin/main.cc

Issue 2759533002: Remove legacy restart code (Closed)
Patch Set: asiva review Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/gen_snapshot.cc ('k') | runtime/include/dart_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/main.cc
diff --git a/runtime/bin/main.cc b/runtime/bin/main.cc
index 0d349eeda72c7904c2ba41ed7f660ab7ba0eb704..112459019c6719c85254a2f7c218f0c02e380505 100644
--- a/runtime/bin/main.cc
+++ b/runtime/bin/main.cc
@@ -761,8 +761,6 @@ static Dart_Handle EnvironmentCallback(Dart_Handle name) {
*exit_code = kCompilationErrorExitCode; \
} else if (Dart_IsApiError(result)) { \
*exit_code = kApiErrorExitCode; \
- } else if (Dart_IsVMRestartRequest(result)) { \
- *exit_code = kRestartRequestExitCode; \
} else { \
*exit_code = kErrorExitCode; \
} \
@@ -1215,11 +1213,6 @@ static void GenerateAppAOTSnapshot() {
#define CHECK_RESULT(result) \
if (Dart_IsError(result)) { \
- if (Dart_IsVMRestartRequest(result)) { \
- Dart_ExitScope(); \
- Dart_ShutdownIsolate(); \
- return true; \
- } \
const int exit_code = Dart_IsCompilationError(result) \
? kCompilationErrorExitCode \
: kErrorExitCode; \
@@ -1253,10 +1246,6 @@ bool RunMainIsolate(const char* script_name, CommandLineOptions* dart_options) {
commandline_packages_file, NULL, &error, &exit_code);
if (isolate == NULL) {
delete[] isolate_name;
- if (exit_code == kRestartRequestExitCode) {
- free(error);
- return true;
- }
Log::PrintErr("%s\n", error);
free(error);
error = NULL;
@@ -1411,8 +1400,7 @@ bool RunMainIsolate(const char* script_name, CommandLineOptions* dart_options) {
result = Dart_RunLoop();
// Generate an app snapshot after execution if specified.
if (gen_snapshot_kind == kAppJIT) {
- if (!Dart_IsCompilationError(result) &&
- !Dart_IsVMRestartRequest(result)) {
+ if (!Dart_IsCompilationError(result)) {
Snapshot::GenerateAppJIT(snapshot_filename);
}
}
« no previous file with comments | « runtime/bin/gen_snapshot.cc ('k') | runtime/include/dart_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698