Remove legacy restart code

runtime/vm/thread.cc

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/thread.h"
 
 #include "vm/compiler_stats.h"
 #include "vm/dart_api_state.h"
 #include "vm/growable_array.h"
 #include "vm/isolate.h"
@@ skipping 256 matching lines @@
   ASSERT(!value.IsNull());
   sticky_error_ = value.raw();
 }
 
 
 void Thread::clear_sticky_error() {
   sticky_error_ = Error::null();
 }
 
 
+RawError* Thread::get_and_clear_sticky_error() {

[siva, 2017/03/16 23:02:30]

NoSafepointScope here as a raw pointer is being held across multiple lines of
code.

[Cutch, 2017/03/20 17:45:26]

Done.

+  RawError* return_value = sticky_error_;
+  sticky_error_ = Error::null();
+  return return_value;
+}
+
+
 const char* Thread::TaskKindToCString(TaskKind kind) {
   switch (kind) {
     case kUnknownTask:
       return "kUnknownTask";
     case kMutatorTask:
       return "kMutatorTask";
     case kCompilerTask:
       return "kCompilerTask";
     case kSweeperTask:
       return "kSweeperTask";
@@ skipping 612 matching lines @@
 
 DisableThreadInterruptsScope::~DisableThreadInterruptsScope() {
   if (thread() != NULL) {
     OSThread* os_thread = thread()->os_thread();
     ASSERT(os_thread != NULL);
     os_thread->EnableThreadInterrupts();
   }
 }
 
 }  // namespace dart