Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2759513002: Remove Factory::NewStringFromASCII method. (Closed)

Created:
3 years, 9 months ago by bbudge
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove Factory::NewStringFromASCII method. BUG=none Review-Url: https://codereview.chromium.org/2759513002 Cr-Commit-Position: refs/heads/master@{#43913} Committed: https://chromium.googlesource.com/v8/v8/+/771e86fdf2cf46f11019210ee37f88711a76a8f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -41 lines) Patch
M src/bootstrapper.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/factory.h View 1 chunk +0 lines, -23 lines 0 comments Download
M src/regexp/regexp-parser.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/wasm/wasm-objects.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/parsing/test-scanner-streams.cc View 3 chunks +7 lines, -11 lines 0 comments Download
M test/cctest/test-strings.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
bbudge
3 years, 9 months ago (2017-03-16 21:55:32 UTC) #4
Benedikt Meurer
LGTM
3 years, 9 months ago (2017-03-17 05:39:23 UTC) #7
bbudge
+Mircea for wasm
3 years, 9 months ago (2017-03-17 14:48:07 UTC) #9
Mircea Trofin
On 2017/03/17 14:48:07, bbudge wrote: > +Mircea for wasm lgtm
3 years, 9 months ago (2017-03-17 16:13:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759513002/1
3 years, 9 months ago (2017-03-17 16:58:17 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/37039)
3 years, 9 months ago (2017-03-17 17:02:10 UTC) #14
bbudge
+Yang for regexp
3 years, 9 months ago (2017-03-17 17:27:47 UTC) #16
Yang
On 2017/03/17 17:27:47, bbudge wrote: > +Yang for regexp lgtm
3 years, 9 months ago (2017-03-17 17:46:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759513002/1
3 years, 9 months ago (2017-03-17 17:50:48 UTC) #19
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 17:52:56 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/771e86fdf2cf46f11019210ee37f88711a7...

Powered by Google App Engine
This is Rietveld 408576698