Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2759433006: [Android] Fix flashing ripple on tab switch toolbar button (Closed)

Created:
3 years, 9 months ago by dgn
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Android] Fix flashing ripple on tab switch toolbar button The ripple was initiated while in the tab switcher but invisible because it's too dark, and is only visible for a short moment when the tab is selected. This makes the ripple invisible while inside the tab switcher. BUG=697455 Review-Url: https://codereview.chromium.org/2734203002 Cr-Commit-Position: refs/heads/master@{#455121} (cherry picked from commit e66cb66e93428dcd00ff059cc27d165b9361ba92) Review-Url: https://codereview.chromium.org/2759433006 . Cr-Commit-Position: refs/branch-heads/3029@{#257} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/5a22d11ca8644fa56e56b981b0bf30055b1f4964

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java View 3 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dgn
3 years, 9 months ago (2017-03-17 11:00:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5a22d11ca8644fa56e56b981b0bf30055b1f4964.

Powered by Google App Engine
This is Rietveld 408576698