Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2734203002: [Android] Fix flashing ripple on tab switch toolbar button (Closed)

Created:
3 years, 9 months ago by dgn
Modified:
3 years, 9 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix flashing ripple on tab switch toolbar button The ripple was initiated while in the tab switcher but invisible because it's too dark, and is only visible for a short moment when the tab is selected. This makes the ripple invisible while inside the tab switcher. BUG=697455 Review-Url: https://codereview.chromium.org/2734203002 Cr-Commit-Position: refs/heads/master@{#455121} Committed: https://chromium.googlesource.com/chromium/src/+/e66cb66e93428dcd00ff059cc27d165b9361ba92

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java View 3 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dgn
PTAL
3 years, 9 months ago (2017-03-07 16:48:08 UTC) #2
Bernhard Bauer
LGTM, thanks!
3 years, 9 months ago (2017-03-07 17:16:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734203002/1
3 years, 9 months ago (2017-03-07 17:35:12 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 17:46:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e66cb66e93428dcd00ff059cc27d...

Powered by Google App Engine
This is Rietveld 408576698